You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "RyukR1 (via GitHub)" <gi...@apache.org> on 2026/06/07 19:56:45 UTC

[PR] Refactor Teradata provider tests to remove legacy unittest imports [airflow]

RyukR1 opened a new pull request, #68190:
URL: https://github.com/apache/airflow/pull/68190

   This PR refactors the test files for the Teradata provider to fully align with Airflow's pytest migration guidelines. 
   
   Specifically, it removes:
   - Unused `import unittest` statements
   - The legacy `if __name__ == "__main__": unittest.main()` execution blocks from the bottom of the files
   
   These files already utilize standard `pytest` decorators, asserts, and mocks, making the legacy `unittest` remnants obsolete.
   
   ### Modified Files:
   - `providers/teradata/tests/unit/teradata/operators/test_bteq.py`
   - `providers/teradata/tests/unit/teradata/utils/test_bteq_util.py`
   - `providers/teradata/tests/unit/teradata/utils/test_encryption_utils.py`
   
   ### Tests Run
   Executed the full Teradata provider test suite inside the local Breeze environment:
   ```bash
   breeze testing providers-tests --test-type "Providers[teradata]"
   ```
   
   
   ##### Was generative AI tooling used to co-author this PR?
   - [X] Yes — Antigravity (Gemini 3.5 Flash)
   Generated-by: Antigravity (Gemini 3.5 Flash) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   EOF
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor Teradata provider tests to remove legacy unittest imports [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #68190:
URL: https://github.com/apache/airflow/pull/68190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor Teradata provider tests to remove legacy unittest imports [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68190:
URL: https://github.com/apache/airflow/pull/68190#issuecomment-4643876340

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor Teradata provider tests to remove legacy unittest imports [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #68190:
URL: https://github.com/apache/airflow/pull/68190#issuecomment-4765676695

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org