[GitHub] [ozone] myskov commented on a diff in pull request #4136: HDDS-7716. Add ACL errors to OM audit logs for read requests

[GitBox <gi...@apache.org>]

myskov commented on code in PR #4136:
URL: https://github.com/apache/ozone/pull/4136#discussion_r1060597615


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -2882,17 +2882,18 @@ public KeyInfoWithVolumeContext getKeyInfo(final OmKeyArgs args,
         perfMetrics.getGetKeyInfoResolveBucketLatencyNs(),
         () -> resolveBucketLink(resolvedVolumeArgs));
 
-    if (isAclEnabled) {
-      captureLatencyNs(perfMetrics.getGetKeyInfoAclCheckLatencyNs(), () ->
-          checkAcls(ResourceType.KEY, StoreType.OZONE, ACLType.READ,
-              bucket.realVolume(), bucket.realBucket(), args.getKeyName())
-      );
-    }

Review Comment:
   nice catch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org