You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/04/23 08:14:49 UTC

[jira] Created: (FELIX-2301) Fix some site.css glitches

Fix some site.css glitches
--------------------------

                 Key: FELIX-2301
                 URL: https://issues.apache.org/jira/browse/FELIX-2301
             Project: Felix
          Issue Type: Improvement
          Components: Documentation
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger


The current CSS of the Apache Felix site [1] IMHO has a few issues:

  * Tables have no broders, thus they are hard to identify as tables and cells are hard to distinguish
  * Tables need a top and bottom margin to set them off from the previous and next elements
  * Table row are align "middle", they should probably be aligned "top" for better readability
  * XML code has an margin on the <pre> element (should be removed like for Java code)
  * Headers h1, h2, and h3 should probably be rendered in bold weight (rather than normal weight)
  * Headers need a top margin, otherwise the "glue" to the previous element

Here is a diff for the proposed changes:

$ diff -b site.css site.css.new 
4c4
< h1, h2, h3, h4, h5, h6 { font-weight: normal; color: #000000; line-height: 100%; margin-top: 0px}
---
> h1, h2, h3, h4, h5, h6 { font-weight: bold; color: #000000; line-height: 100% }
8,10c8,10
< h4 { font-size: 140% }
< h5 { font-size: 130% }
< h6 { font-size: 120% }
---
> h4 { font-size: 140%; font-weight: normal }
> h5 { font-size: 130%; font-weight: normal }
> h6 { font-size: 120%; font-weight: normal }
25a26,29
> .code-xml { margin: 0em }
> 
> table.confluenceTable { border-collapse: collapse; margin: 10px 0 10px 0 }
> td.confluenceTd { border:1px solid #CCCCCC; padding:5px; vertical-align:top; }

WDYT ?


[1] http://felix.apache.org/site/media.data/site.css

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2301) Fix some site.css glitches

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-2301.
--------------------------------------

    Resolution: Fixed

Applied the patch to the site.css and uploaded to https://cwiki.apache.org/confluence/download/attachments/60543/site.css

Should be public in a few hours

> Fix some site.css glitches
> --------------------------
>
>                 Key: FELIX-2301
>                 URL: https://issues.apache.org/jira/browse/FELIX-2301
>             Project: Felix
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>
> The current CSS of the Apache Felix site [1] IMHO has a few issues:
>   * Tables have no broders, thus they are hard to identify as tables and cells are hard to distinguish
>   * Tables need a top and bottom margin to set them off from the previous and next elements
>   * Table row are align "middle", they should probably be aligned "top" for better readability
>   * XML code has an margin on the <pre> element (should be removed like for Java code)
>   * Headers h1, h2, and h3 should probably be rendered in bold weight (rather than normal weight)
>   * Headers need a top margin, otherwise the "glue" to the previous element
> Here is a diff for the proposed changes:
> $ diff -b site.css site.css.new 
> 4c4
> < h1, h2, h3, h4, h5, h6 { font-weight: normal; color: #000000; line-height: 100%; margin-top: 0px}
> ---
> > h1, h2, h3, h4, h5, h6 { font-weight: bold; color: #000000; line-height: 100% }
> 8,10c8,10
> < h4 { font-size: 140% }
> < h5 { font-size: 130% }
> < h6 { font-size: 120% }
> ---
> > h4 { font-size: 140%; font-weight: normal }
> > h5 { font-size: 130%; font-weight: normal }
> > h6 { font-size: 120%; font-weight: normal }
> 25a26,29
> > .code-xml { margin: 0em }
> > 
> > table.confluenceTable { border-collapse: collapse; margin: 10px 0 10px 0 }
> > td.confluenceTd { border:1px solid #CCCCCC; padding:5px; vertical-align:top; }
> WDYT ?
> [1] http://felix.apache.org/site/media.data/site.css

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.