[jira] [Resolved] (EAGLE-844) Potential NPE issue

["Hao Chen (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/EAGLE-844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hao Chen resolved EAGLE-844.
----------------------------
    Resolution: Fixed

> Potential NPE issue
> -------------------
>
>                 Key: EAGLE-844
>                 URL: https://issues.apache.org/jira/browse/EAGLE-844
>             Project: Eagle
>          Issue Type: Bug
>          Components: Query Engine
>    Affects Versions: v0.5.0
>            Reporter: Jaechang Nam
>            Assignee: wujinhu
>            Priority: Minor
>             Fix For: v0.5.0
>
>
> The following file accessed on Dec 18 2016 (Github revision id: 8fe968cb7e340e2f21711b5a0f701e760cb91d59), eagle-core/eagle-query/eagle-storage-hbase/src/main/java/org/apache/eagle/storage/hbase/HBaseEntitySchemaManager.java, seems to have a potential null pointer exception.
> {code}
> Map<String, EntityDefinition> entityServiceMap = EntityDefinitionManager.entities();
>             if (entityServiceMap != null || entityServiceMap.values() != null) {
>                 for (EntityDefinition entityDefinition : entityServiceMap.values()) {
>                     createTable(entityDefinition);
>                 }
>             }
> {code}
> if entityServiceMap is null, entityServiceMap.values() could have NPE.
> I have no idea if entityServiceMap can be null. Having said that, at least it could be a code smell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)