[GitHub] [spark] LuciferYang commented on a diff in pull request #40541: [SPARK-42861][SQL] Use private[sql] instead of protected[sql] to avoid generating API doc

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40541:
URL: https://github.com/apache/spark/pull/40541#discussion_r1147139671


##########
sql/core/src/main/scala/org/apache/spark/sql/RuntimeConfig.scala:
##########
@@ -64,7 +64,7 @@ class RuntimeConfig private[sql](sqlConf: SQLConf = new SQLConf) {
   /**
    * Sets the given Spark runtime configuration property.
    */
-  protected[sql] def set[T](entry: ConfigEntry[T], value: T): Unit = {
+  private[sql] def set[T](entry: ConfigEntry[T], value: T): Unit = {

Review Comment:
   Other places have been `protected[sql]` since 2016. Do we also need to weaken the access scope?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org