[GitHub] [helix] desaikomal commented on a diff in pull request #2353: Implement direct child change listener in ZkMetaClient

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2353:
URL: https://github.com/apache/helix/pull/2353#discussion_r1094694825


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -258,7 +260,12 @@ public boolean subscribeDataChange(String key, DataChangeListener listener,
   public DirectChildSubscribeResult subscribeDirectChildChange(String key,
       DirectChildChangeListener listener, boolean skipWatchingNonExistNode,
       boolean persistListener) {

Review Comment:
   I agree. API change can be separate from this PR. Junkai wants to keep our APIs crisp and so I also agree that having 2 apis explicitly calling persistent vs/vs one time can be different api. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org