[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #124: DSL Viewer ignored literals; this fixes that and tidies the code a bit
URL: https://github.com/apache/brooklyn-ui/pull/124#discussion_r264205057
 
 

 ##########
 File path: ui-modules/blueprint-composer/app/components/dsl-viewer/dsl-viewer.js
 ##########
 @@ -42,18 +42,24 @@ export function dslViewerDirective() {
     };
 
     function link(scope) {
-        scope.isTargetDsl = (dsl) => {
-            return dsl.kind === KIND.TARGET;
+        
+        scope.getIcon = (dsl) => {
 
 Review comment:
   good point; now uses `scope.$watch`; also a few other fixes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services