You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2016/12/03 01:51:19 UTC
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/
-----------------------------------------------------------
(Updated Dec. 3, 2016, 9:51 a.m.)
Review request for mesos and Jie Yu.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flag '--oci_store_dir'.
Diffs
-----
docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637
docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5
src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44
src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f
Diff: https://reviews.apache.org/r/52379/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
> On Jan. 9, 2017, 5:03 p.m., Gilbert Song wrote:
> > src/slave/flags.cpp, line 174
> > <https://reviews.apache.org/r/52379/diff/6/?file=1596001#file1596001line174>
> >
> > Why not consistent with docker/appc store?
This was a suggestion of Avinash when he reviewed the design doc, the reason that we do not choose /tmp/mesos/store/oci is, /tmp is a tmpfs (or ramfs) an in-memory file system, the OCI images can be quite big (as with docker images) and might end up filling this file system very fast. And another reason is /tmp will be automatically cleared upon agent host reboot which is also what we do not want.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review160873
-----------------------------------------------------------
On Jan. 3, 2017, 10:17 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 10:17 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153
> src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3
> src/slave/http.cpp b6e2d4f9190358d113b39140d116b8659ddbb49b
>
> Diff: https://reviews.apache.org/r/52379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review160873
-----------------------------------------------------------
src/slave/flags.cpp (line 174)
<https://reviews.apache.org/r/52379/#comment232123>
Why not consistent with docker/appc store?
- Gilbert Song
On Jan. 3, 2017, 6:17 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 6:17 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153
> src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3
> src/slave/http.cpp b6e2d4f9190358d113b39140d116b8659ddbb49b
>
> Diff: https://reviews.apache.org/r/52379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
> On Feb. 5, 2017, 12:18 p.m., Jie Yu wrote:
> > src/slave/flags.cpp
> > Lines 173 (patched)
> > <https://reviews.apache.org/r/52379/diff/7/?file=1621012#file1621012line173>
> >
> > Let's make the default /tmp/mesos/store/oci, to be consistent with others.
This was a suggestion of Avinash when he reviewed the design doc, the reason that we do not choose /tmp/mesos/store/oci is, /tmp is a tmpfs (or ramfs) an in-memory file system, the OCI images can be quite big (as with docker images) and might end up filling this file system very fast. And another reason is /tmp will be automatically cleared upon agent host reboot which is also what we do not want.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review164265
-----------------------------------------------------------
On Feb. 1, 2017, 9:15 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 9:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
> src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
>
>
> Diff: https://reviews.apache.org/r/52379/diff/7/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review164265
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/flags.cpp (line 173)
<https://reviews.apache.org/r/52379/#comment235933>
Let's make the default /tmp/mesos/store/oci, to be consistent with others.
- Jie Yu
On Feb. 1, 2017, 1:15 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1:15 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
> src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
>
> Diff: https://reviews.apache.org/r/52379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/
-----------------------------------------------------------
(Updated March 30, 2017, 9:37 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flag '--oci_store_dir'.
Diffs
-----
docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
Diff: https://reviews.apache.org/r/52379/diff/7/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 9:15 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flag '--oci_store_dir'.
Diffs (updated)
-----
docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
src/slave/http.cpp d68c9adc1db43c2e853c8b2290705fdc7739d45c
Diff: https://reviews.apache.org/r/52379/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 10:17 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flag '--oci_store_dir'.
Diffs (updated)
-----
docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d
docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153
src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3
src/slave/http.cpp b6e2d4f9190358d113b39140d116b8659ddbb49b
Diff: https://reviews.apache.org/r/52379/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/
-----------------------------------------------------------
(Updated Dec. 11, 2016, 10:16 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flag '--oci_store_dir'.
Diffs (updated)
-----
docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637
docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
src/slave/flags.hpp 02af2845e8c2baf03c83c7eab897725f6e2e9752
src/slave/flags.cpp 74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
src/slave/http.cpp 372cd61ede1668db8cd7f9f7ebaedd16a368de65
Diff: https://reviews.apache.org/r/52379/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Qian Zhang <zh...@gmail.com>.
> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1606
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571599#file1571599line1606>
> >
> > Just checking: Isn't the `configuration.md` auto-generated?
> > https://issues.apache.org/jira/browse/MESOS-4298
Not yet, see https://issues.apache.org/jira/browse/MESOS-4557 which is still open now.
> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > docs/configuration.md, line 1609
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571599#file1571599line1609>
> >
> > Directory in which the OCI provisioner will store images.
Any differece between your proposed version and my version? Basically I'd like to keep it consistent with `--appc_store_dir` and `--docker_store_dir`.
> On Dec. 7, 2016, 12:26 a.m., Avinash sridharan wrote:
> > src/slave/flags.cpp, line 167
> > <https://reviews.apache.org/r/52379/diff/4/?file=1571603#file1571603line167>
> >
> > Directory in which the OCI provisioner stores images.
Ditto.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review158169
-----------------------------------------------------------
On Dec. 3, 2016, 9:51 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 9:51 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5
> src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44
> src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f
>
> Diff: https://reviews.apache.org/r/52379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 52379: Added agent flag '--oci_store_dir'.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52379/#review158169
-----------------------------------------------------------
docs/configuration.md (line 1606)
<https://reviews.apache.org/r/52379/#comment228917>
Just checking: Isn't the `configuration.md` auto-generated?
https://issues.apache.org/jira/browse/MESOS-4298
docs/configuration.md (line 1609)
<https://reviews.apache.org/r/52379/#comment228916>
Directory in which the OCI provisioner will store images.
src/slave/flags.cpp (line 167)
<https://reviews.apache.org/r/52379/#comment228918>
Directory in which the OCI provisioner stores images.
- Avinash sridharan
On Dec. 3, 2016, 1:51 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52379/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 1:51 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flag '--oci_store_dir'.
>
>
> Diffs
> -----
>
> docs/configuration.md efe3e9bd9d203a7ba44adf4ead24f14b8b577637
> docs/endpoints/slave/state.json.md 0f82c1926404e79b281b2ea5f4d0ca21323aeded
> docs/endpoints/slave/state.md b34459e8624f0b29e927ff79be7fc845ac88080b
> src/slave/flags.hpp c6c3197bbf30ec617751f4a1a34914c0f0e29eb5
> src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44
> src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f
>
> Diff: https://reviews.apache.org/r/52379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>