[jira] [Updated] (OFBIZ-4427) Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation

["Paul Foxworthy (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Foxworthy updated OFBIZ-4427:
----------------------------------

    Attachment: OFBIZ-4427_isEmpty.patch

Here's a new patch.
I have:
- deprecated UtilValidate.isEmpty(Object) and UtilValidate.isNotEmpty(Object)
- added overloaded variants of these two methods with an Object[] parameter
- Removed isEmpty(String) and isNotEmpty(String), because String derives from CharSequence, and there is already a CharSequence overload for these methods
- detected and fixed many calls to isEmpty and isNotEmpty when all that was needed was a comparison with null

There are still many calls remaining, but they will set off a deprecation warning, so if several of us work at resolving those we can eventually eliminate the methods
                
> Possible runtime errors with UtilValidate.isEmpty(Object) should be rather caught during compilation
> ----------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-4427
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4427
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>              Labels: UtilValidate.isEmpty
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-4427.patch, OFBIZ-4427_isEmpty.patch
>
>
> Hence we need tp remove the UtilValidate.isEmpty(Object) method and provide methods that accept explicit types.  
> Scripting languages should use a facade class that provides methods for working with generic Objects or providing default behaviors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira