You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2026/09/25 21:45:05 UTC

[Impala-ASF-CR] IMPALA-11917: Fix clang-analyzer-security.insecureAPI.bzero

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24951


Change subject: IMPALA-11917: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................

IMPALA-11917: Fix clang-analyzer-security.insecureAPI.bzero

Replace obsolete bzero calls with equivalent memset calls in compression, networking, and test code.

Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Assisted-by: GPT-5.6-Sol (GitHub Copilot)
---
M .clang-tidy
M be/src/runtime/data-stream-test.cc
M be/src/util/compress.cc
M be/src/util/decompress.cc
M be/src/util/network-util.cc
5 files changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/24951/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14418/ DRY_RUN=false


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 17:46:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24846/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Nov 2026 01:20:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Balazs Hevele has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 06:12:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    https://gerrit.cloudera.org/24951

to look at the new patch set (#2).

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................

IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Replace obsolete bzero calls with equivalent memset calls in
compression, networking, and test code.

Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Assisted-by: GPT-5.6-Sol (GitHub Copilot)
---
M .clang-tidy
M be/src/runtime/data-stream-test.cc
M be/src/util/compress.cc
M be/src/util/decompress.cc
M be/src/util/network-util.cc
5 files changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/24951/2
-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Jiyoung Yoo (Code Review)" <ge...@cloudera.org>.
Jiyoung Yoo has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 17:00:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 22:22:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11917: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24951 )

Change subject: IMPALA-11917: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/24197/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 25 Sep 2026 22:12:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................

IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Replace obsolete bzero calls with equivalent memset calls in
compression, networking, and test code.

Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Assisted-by: GPT-5.6-Sol (GitHub Copilot)
Reviewed-on: https://gerrit.cloudera.org/24951
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .clang-tidy
M be/src/runtime/data-stream-test.cc
M be/src/util/compress.cc
M be/src/util/decompress.cc
M be/src/util/network-util.cc
5 files changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 17:44:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( https://gerrit.cloudera.org/24951 )

Change subject: IMPALA-15745: Fix clang-analyzer-security.insecureAPI.bzero
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit https://gerrit.cloudera.org/24951
To unsubscribe, visit https://gerrit.cloudera.org/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief909f5108d36ee7916170b1adc2216673a27d5d
Gerrit-Change-Number: 24951
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Jiyoung Yoo <ji...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Nov 2026 17:46:07 +0000
Gerrit-HasComments: No