[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #159: Disallow sendShuffleData if requireBufferId expired

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #159:
URL: https://github.com/apache/incubator-uniffle/pull/159#discussion_r948595254


##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -290,10 +278,22 @@ public RssSendShuffleDataResponse sendShuffleData(RssSendShuffleDataRequest requ
     return response;
   }
 
-  private SendShuffleDataResponse doSendData(SendShuffleDataRequest rpcRequest) {
+  private SendShuffleDataResponse doSendData(String appId, int size, RssSendShuffleDataRequest request,
+                                             Map.Entry<Integer, Map<Integer, List<ShuffleBlockInfo>>> stb,
+                                             List<ShuffleData> shuffleData) {
     int retryNum = 0;
     while (retryNum < maxRetryAttempts) {
       try {
+        long requireId = requirePreAllocation(size, request.getRetryMax(), request.getRetryIntervalMax());

Review Comment:
   Could we reuse RetryUtils?



##########
internal-client/src/main/java/org/apache/uniffle/client/impl/grpc/ShuffleServerGrpcClient.java:
##########
@@ -109,7 +109,7 @@ public ShuffleServerGrpcClient(String host, int port, int maxRetryAttempts, bool
     blockingStub = ShuffleServerGrpc.newBlockingStub(channel);
   }
   
-  private ShuffleServerBlockingStub getBlockingStub() {
+  public ShuffleServerBlockingStub getBlockingStub() {

Review Comment:
   Could we use `default access modifier`? It seems enough to use `package-private` .
   ```
   ShuffleServerBlockingStub getBlockingStub()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org