You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by su...@apache.org on 2012/12/02 04:02:59 UTC

svn commit: r1416102 - in /hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common: CHANGES.branch-trunk-win.txt src/main/winutils/ls.c

Author: suresh
Date: Sun Dec  2 03:02:58 2012
New Revision: 1416102

URL: http://svn.apache.org/viewvc?rev=1416102&view=rev
Log:
HADOOP-9110. winutils ls off-by-one error indexing MONTHS array can cause access violation. Contributed by Chris Nauroth.

Modified:
    hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/CHANGES.branch-trunk-win.txt
    hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/src/main/winutils/ls.c

Modified: hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/CHANGES.branch-trunk-win.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/CHANGES.branch-trunk-win.txt?rev=1416102&r1=1416101&r2=1416102&view=diff
==============================================================================
--- hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/CHANGES.branch-trunk-win.txt (original)
+++ hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/CHANGES.branch-trunk-win.txt Sun Dec  2 03:02:58 2012
@@ -56,3 +56,6 @@ branch-trunk-win changes - unreleased
 
   HADOOP-9011. saveVersion.py does not include branch in version annotation.
   (Chris Nauroth via suresh)
+
+  HADOOP-9110. winutils ls off-by-one error indexing MONTHS array can cause 
+  access violation. (Chris Nauroth via suresh)

Modified: hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/src/main/winutils/ls.c
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/src/main/winutils/ls.c?rev=1416102&r1=1416101&r2=1416102&view=diff
==============================================================================
--- hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/src/main/winutils/ls.c (original)
+++ hadoop/common/branches/branch-trunk-win/hadoop-common-project/hadoop-common/src/main/winutils/ls.c Sun Dec  2 03:02:58 2012
@@ -119,7 +119,7 @@ static BOOL LsPrintLine(
 
   fwprintf(stdout, L"%10s %d %s %s %lld %3s %2d %4d %s\n",
     maskString, hardlinkCount, ownerName, groupName, fileSize.QuadPart,
-    MONTHS[stFileWriteTime.wMonth], stFileWriteTime.wDay,
+    MONTHS[stFileWriteTime.wMonth-1], stFileWriteTime.wDay,
     stFileWriteTime.wYear, path);
 
   ret = TRUE;