You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by kishoreg <gi...@git.apache.org> on 2017/03/24 17:54:55 UTC
[GitHub] helix pull request #77: Adding support to batch ZK callback optionally by se...
GitHub user kishoreg opened a pull request:
https://github.com/apache/helix/pull/77
Adding support to batch ZK callback optionally by setting sys var asy\u2026
Supports batching of zk callbacks. Can be enabled optionally with a system flag (asyncBatchModeEnabled=true).
In my test cluster with 1000 resources, I find the number of callbacks processed from ZK reduces from 2.4k to 119. This speeds up the controller and also reduces the load on ZK
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishoreg/helix zk-callback-batching
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 384978a2e16ab0f4adb388e32c7e448c77996ca2
Author: kishoreg <ki...@apache.org>
Date: 2017-03-24T17:48:05Z
Adding support to batch ZK callback optionally by setting sys var asyncBatchModeEnabled=true
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix issue #77: Adding support to batch ZK callback optionally by setting s...
Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the issue:
https://github.com/apache/helix/pull/77
I think it's a good idea to have one shared thread pool. Since we create one callback per helix entity type (idealstate, external view), I thought this is not a big overhead. One problem is for the current state property key which will spawn one thread per participant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] helix pull request #77: Adding support to batch ZK callback optionally by se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/helix/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---