You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/18 15:47:50 UTC
[GitHub] [airflow] potiuk opened a new pull request #18346: Explain sentry default environment variable for subprocess hook
potiuk opened a new pull request #18346:
URL: https://github.com/apache/airflow/pull/18346
Sentry by default monkey-patches standard library POpen function
to capture and pass current process' environment to subprocess
with `SUBPROCESS_` prefix. This break SubprocessHook tests
when sentry tests are run before SubprocessHook tests, and also
it modifies SubprocessHook behaviour (and promise) in production
environment as well.
This PR:
* adds documentation to both sentry documentation and the
SubprocessHook documentation explaining the interaction between
the two
* Adds documentation explaining how to disable this default
Sentry behaviour
* disables default integrations in the Sentry tests to avoid
side-effects
Fixes: #18268
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18346: Explain sentry default environment variable for subprocess hook
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18346:
URL: https://github.com/apache/airflow/pull/18346#issuecomment-922333674
cc: @ecerulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18346: Explain sentry default environment variable for subprocess hook
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18346:
URL: https://github.com/apache/airflow/pull/18346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18346: Explain sentry default environment variable for subprocess hook
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18346:
URL: https://github.com/apache/airflow/pull/18346#issuecomment-922341055
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #18346: Explain sentry default environment variable for subprocess hook
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #18346:
URL: https://github.com/apache/airflow/pull/18346#discussion_r711609023
##########
File path: docs/apache-airflow/logging-monitoring/errors.rst
##########
@@ -70,3 +70,24 @@ Name Description
``completed_tasks[operator]`` Task operator of task that executed before failed task
``completed_tasks[duration]`` Duration in seconds of task that executed before failed task
======================================= ==============================================================
+
+
+Impact os Sentry on Environment variables passed to Subprocess Hook
Review comment:
```suggestion
Impact of Sentry on Environment variables passed to Subprocess Hook
```
Maybe a typo ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org