[jira] Resolved: (LUCY-85) FSFolder

["Marvin Humphrey (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCY-85?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marvin Humphrey resolved LUCY-85.
---------------------------------

    Resolution: Fixed

Committed as r888114.

> FSFolder
> --------
>
>                 Key: LUCY-85
>                 URL: https://issues.apache.org/jira/browse/LUCY-85
>             Project: Lucy
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Marvin Humphrey
>            Assignee: Marvin Humphrey
>         Attachments: FSFolder.bp, FSFolder.c, FSFolder.pm, fsfolder_support.diff, TestFolderCommon.bp, TestFolderCommon.c, TestFSFolder.bp, TestFSFolder.c
>
>
> FSFolder is a file-system-based implementation of Folder.
> FSFolder.c is reasonably compact: 347 lines of code.  This has been made
> possible by offloading as much as possible, e.g. directory iteration into
> FSDirHandle.c (286 lines of code, lots of OS-specific stuff).  
> We should continue to try to put stuff elsewhere, because Folder will tend to
> be the class where OS interaction routines accumulate first.  For instance, I
> think we'll need a Stat class soon.  That way, we can have a single method,
> Folder_Stat(), instead of methods like Folder_Is_Directory(),
> Folder_File_Length(), Folder_Num_Hard_Links(), and so on.
> In order to address thread safety for FSFolder, we'll need to make the
> "entries" Hash thread safe (as we will for all Folder subclasses).  Aside from
> that and reference counting, I think it's pretty close.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.