You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/04/02 08:50:03 UTC
[jira] [Commented] (AIRFLOW-4193) Remove code duplication in
test_gcp_api_base_hook
[ https://issues.apache.org/jira/browse/AIRFLOW-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807544#comment-16807544 ]
ASF subversion and git services commented on AIRFLOW-4193:
----------------------------------------------------------
Commit 4d98a4127a7846e75261c0c1297a8cbadb91b9ab in airflow's branch refs/heads/fd-increase-pd-size from BasPH
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=4d98a41 ]
[AIRFLOW-4193] Remove code duplication in test_gcp_api_base_hook (#5011)
> Remove code duplication in test_gcp_api_base_hook
> -------------------------------------------------
>
> Key: AIRFLOW-4193
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4193
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Bas Harenslak
> Assignee: Fokko Driesprong
> Priority: Major
> Fix For: 2.0.0
>
>
> test_gcp_api_base_hook contains 5 tests which test pretty much the same thing. `@parameterized` was already used in some way, so generalized all 5 tests and removed lots of duplicate code as a result.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)