You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/08/08 22:30:46 UTC

[GitHub] [kvrocks] PragmaTwice edited a comment on the discussion: Talks about the design of consumer group in stream

GitHub user PragmaTwice edited a comment on the discussion: Talks about the design of consumer group in stream

I think you can add them to `StreamMetadata`, but to maintain the data compatiblity, you need to check the length of stream metadata, e.g.
```
StreamMetadata::Encode() {
  if (length > original_len) {
    group_enable = true;
    ParseRestPart();
  } else {
    group_enable = false;
  }
}
```
So that the original user data of Stream type (without group fields) will be read and written normally.

GitHub link: https://github.com/apache/kvrocks/discussions/1654#discussioncomment-6673993

----
This is an automatically sent email for issues@kvrocks.apache.org.
To unsubscribe, please send an email to: issues-unsubscribe@kvrocks.apache.org