You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2021/05/07 07:30:14 UTC
[kudu-CR] KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17409
Change subject: KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
......................................................................
KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
The test failed because the original perf improvement score
of flush/compaction ops in hot tablet may be always higher
than that in cold tablet. This patch fixed it by increasing
`FLAGS_flush_threshold_mb` and `FLAGS_flush_upper_bound_ms`
and reducing the amount of data written in hot tablet, so
the cold tablet would be compacted if
'workload_score_for_perf_improvement_ops' was diabled.
Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/17409/1
--
To view, visit http://gerrit.cloudera.org:8080/17409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
Gerrit-Change-Number: 17409
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17409 )
Change subject: KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
......................................................................
Patch Set 1:
Thanks a lot for the fix!
--
To view, visit http://gerrit.cloudera.org:8080/17409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
Gerrit-Change-Number: 17409
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 May 2021 19:22:08 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17409 )
Change subject: KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
Gerrit-Change-Number: 17409
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 07 May 2021 19:21:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17409 )
Change subject: KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
......................................................................
KUDU-3280: fix flakiness in TabletServerTest.TestStarvePerfImprovementOpsInColdTablet
The test failed because the original perf improvement score
of flush/compaction ops in hot tablet may be always higher
than that in cold tablet. This patch fixed it by increasing
`FLAGS_flush_threshold_mb` and `FLAGS_flush_upper_bound_ms`
and reducing the amount of data written in hot tablet, so
the cold tablet would be compacted if
'workload_score_for_perf_improvement_ops' was diabled.
Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
Reviewed-on: http://gerrit.cloudera.org:8080/17409
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17409
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fca72965f25c14446741cc9602c4690404933f4
Gerrit-Change-Number: 17409
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)