You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by he...@apache.org on 2022/08/24 12:27:31 UTC

[brooklyn-server] 02/05: better logging on group changes

This is an automated email from the ASF dual-hosted git repository.

heneveld pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brooklyn-server.git

commit faf59badb0f650498da3b1727f3b841c31f55751
Author: Alex Heneveld <al...@cloudsoft.io>
AuthorDate: Wed Aug 24 12:59:58 2022 +0100

    better logging on group changes
---
 .../java/org/apache/brooklyn/entity/group/GroupsChangePolicy.java   | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/core/src/main/java/org/apache/brooklyn/entity/group/GroupsChangePolicy.java b/core/src/main/java/org/apache/brooklyn/entity/group/GroupsChangePolicy.java
index d35f44911d..2c50c2d343 100644
--- a/core/src/main/java/org/apache/brooklyn/entity/group/GroupsChangePolicy.java
+++ b/core/src/main/java/org/apache/brooklyn/entity/group/GroupsChangePolicy.java
@@ -182,10 +182,10 @@ public class GroupsChangePolicy extends AbstractMembershipTrackingPolicy {
 
                         BrooklynClassLoadingContext loader = member != null ? RegisteredTypes.getClassLoadingContext(member) : null;
                         TypeToken<? extends EntityInitializer> typeToken = getType(loader, type);
-                        LOG.debug("type='{}', typeToken='{}'",type, typeToken);
                         Maybe<? extends EntityInitializer> entityInitializerMaybe = BeanWithTypeUtils.tryConvertOrAbsentUsingContext(Maybe.of(stringObjectMap), typeToken);
                         if (entityInitializerMaybe.isPresent()) {
                             EntityInitializer initializer = entityInitializerMaybe.get();
+                            LOG.info("Applying initializer '{}' to member '{}'", initializer, member);
                             initializer.apply((EntityInternal) member);
                         } else {
                             LOG.debug("Unable to initialize {} due to {}", type, Maybe.getException(entityInitializerMaybe), Maybe.getException(entityInitializerMaybe));
@@ -210,8 +210,8 @@ public class GroupsChangePolicy extends AbstractMembershipTrackingPolicy {
                     }
                     policySpec.configure((Map<String, Object>) stringObjectMap.get(BROOKLYN_CONFIG));
 
-
                     AbstractTypePlanTransformer.checkSecuritySensitiveFields(policySpec);
+                    LOG.info("Adding policy '{}' to member '{}'", policySpec, member);
                     member.policies().add(policySpec);
                 }
         );
@@ -230,11 +230,13 @@ public class GroupsChangePolicy extends AbstractMembershipTrackingPolicy {
                     enricherSpec.configure((Map<String, Object>) stringObjectMap.get(BROOKLYN_CONFIG));
 
                     AbstractTypePlanTransformer.checkSecuritySensitiveFields(enricherSpec);
+                    LOG.info("Adding enricher '{}' to member '{}'", enricherSpec, member);
                     member.enrichers().add(enricherSpec);
                 }
         );
 
         config().get(INVOKE).forEach(effName -> {
+            LOG.info("Invoking effector '{}' on member '{}'", effName, member);
             member.invoke( ((EntityInternal)member).getEffector(effName), MutableMap.of() );
         });
     }