You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/14 11:22:58 UTC
[GitHub] [airflow] nuclearpinguin opened a new pull request #7420:
[AIRFLOW-6558] Campaign Manager operators for conversions
nuclearpinguin opened a new pull request #7420: [AIRFLOW-6558] Campaign Manager operators for conversions
URL: https://github.com/apache/airflow/pull/7420
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] efolgar commented on a change in pull request #7420:
[AIRFLOW-6558] Campaign Manager operators for conversions
Posted by GitBox <gi...@apache.org>.
efolgar commented on a change in pull request #7420: [AIRFLOW-6558] Campaign Manager operators for conversions
URL: https://github.com/apache/airflow/pull/7420#discussion_r381407464
##########
File path: airflow/providers/google/marketing_platform/example_dags/example_campaign_manager.py
##########
@@ -48,6 +54,33 @@
},
}
+CONVERSION = {
+ "kind": "dfareporting#conversion",
+ "floodlightActivityId": FLOODLIGHT_ACTIVITY_ID,
+ "floodlightConfigurationId": FLOODLIGHT_CONFIGURATION_ID,
+ "mobileDeviceId": "E95AE36E-A242-4A20-AB40-CA85BBBDA915",
Review comment:
Remove hardcoded mobile device id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7420: [AIRFLOW-6558] Campaign
Manager operators for conversions
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7420: [AIRFLOW-6558] Campaign Manager operators for conversions
URL: https://github.com/apache/airflow/pull/7420
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7420: [AIRFLOW-6558] Campaign Manager operators for conversions
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7420: [AIRFLOW-6558] Campaign Manager operators for conversions
URL: https://github.com/apache/airflow/pull/7420#discussion_r381964276
##########
File path: airflow/providers/google/marketing_platform/example_dags/example_campaign_manager.py
##########
@@ -48,6 +54,33 @@
},
}
+CONVERSION = {
+ "kind": "dfareporting#conversion",
+ "floodlightActivityId": FLOODLIGHT_ACTIVITY_ID,
+ "floodlightConfigurationId": FLOODLIGHT_CONFIGURATION_ID,
+ "mobileDeviceId": "E95AE36E-A242-4A20-AB40-CA85BBBDA915",
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services