You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/08 11:02:13 UTC
[GitHub] [pulsar] lhotari opened a new pull request #12666: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf
lhotari opened a new pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666
### Motivation
- https://github.com/apache/bookkeeper/pull/2646 added "Auto-throttle read operations" which is enabled by default
### Modifications
- Add `readWorkerThreadsThrottlingEnabled=true` to `conf/bookkeeper.conf` since that is the default value in BookKeeper that gets used unless the setting is explicitly set to `false`.
### Open questions
- Is `readWorkerThreadsThrottlingEnabled=true` a safe default?
- There's a warning in https://netty.io/4.0/api/io/netty/channel/ChannelFuture.html about calling `.await()` and https://github.com/apache/bookkeeper/pull/2646 uses that `ChannelFuture.await()` to block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #12666: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666#issuecomment-963037964
@dlg99 Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12666: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #12666: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666#issuecomment-964765135
> This is the line for whom is interested in checking out the source code in BK
The `await()` is safe since we're (in practice) always doing the read operations from a BK pool of threads dedicated to read, and not from Netty IO threads.
The purpose is indeed to apply back-pressure and avoid unlimited memory usage in the Bookie.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #12666: [Config] Add readWorkerThreadsThrottlingEnabled to conf/bookkeeper.conf
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #12666:
URL: https://github.com/apache/pulsar/pull/12666#issuecomment-963051670
@merlimat can you please comment on the 'open question' ?
This is the line for whom is interested in checking out the source code in BK
https://github.com/apache/bookkeeper/pull/2646/files#diff-329b56111e8bed86869212b7f1b7027a2ee791cd8476465d127d345128cc9b84R86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org