You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "xiedeyantu (via GitHub)" <gi...@apache.org> on 2025/09/28 16:12:12 UTC
[PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
xiedeyantu opened a new pull request, #4561:
URL: https://github.com/apache/calcite/pull/4561
See: [CALCITE-7205](https://issues.apache.org/jira/browse/CALCITE-7205)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde commented on code in PR #4561:
URL: https://github.com/apache/calcite/pull/4561#discussion_r2389624914
##########
core/src/main/java/org/apache/calcite/rel/metadata/FunctionalDependencies.java:
##########
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.metadata;
+
+import com.google.common.collect.ImmutableSet;
+
+import java.util.ArrayDeque;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Models a set of functional dependencies and provides methods for closure computation,
+ * candidate key search, and related reasoning.
+ */
+public class FunctionalDependencies {
Review Comment:
Yes, you can use abbreviations, sparingly.
One option is to do as you have done, which is to use noun phrases.
But the other is to pick a short noun and define it (and each of the related concepts). "An Arrow is ... The functional dependency 'empno functionally determines (sal, deptno)' is represented by the following two arrows ..."
This is what mathematicians do. If you do this, you will not need to use abbreviations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu closed pull request #4561: [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies
URL: https://github.com/apache/calcite/pull/4561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3343881417
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561) **Quality Gate passed**
Issues
 [10 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [79.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3352965066
> I have approved this PR already. The basic architecture is right. On naming, if Julian is happy, I am happy.
Thanks, Mihai. Then let's wait for Julian's opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3352935713
I have approved this PR already. The basic architecture is right. On naming, if Julian is happy, I am happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3351293345
I have updated the JavaDoc and also changed the class names. I have covered most scenarios in the test classes as much as possible. I believe testing is still necessary. If @julianhyde disagrees with having a separate test file, I can integrate it into `RelMetadataTest`.
Could @julianhyde and @mihaibudiu please take another look to see if this PR can be merged independently? If it is not approved, I can also continue to incorporate these changes into [CALCITE-5913](https://issues.apache.org/jira/browse/CALCITE-5913).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde commented on code in PR #4561:
URL: https://github.com/apache/calcite/pull/4561#discussion_r2389606045
##########
core/src/main/java/org/apache/calcite/rel/metadata/FunctionalDependencies.java:
##########
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.metadata;
+
+import com.google.common.collect.ImmutableSet;
+
+import java.util.ArrayDeque;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Models a set of functional dependencies and provides methods for closure computation,
+ * candidate key search, and related reasoning.
+ */
+public class FunctionalDependencies {
Review Comment:
This class at first looks like a nice low-level library for functional dependencies. Its plural name implies that it is a utility class but it is not a utility class: it has data fields and is instantiable.
You use terms like 'dependent' and 'determinant' without defining them.
I think this can be fixed. You need to find better names than "FunctionalDependencies" and "FunctionalDependency", and you need to write a reasonable amount of javadoc with some examples in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4561:
URL: https://github.com/apache/calcite/pull/4561#discussion_r2389612829
##########
core/src/main/java/org/apache/calcite/rel/metadata/FunctionalDependencies.java:
##########
@@ -0,0 +1,305 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.calcite.rel.metadata;
+
+import com.google.common.collect.ImmutableSet;
+
+import java.util.ArrayDeque;
+import java.util.Comparator;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.PriorityQueue;
+import java.util.Queue;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Models a set of functional dependencies and provides methods for closure computation,
+ * candidate key search, and related reasoning.
+ */
+public class FunctionalDependencies {
Review Comment:
@julianhyde I agree. Let me start with the naming issue. I've always felt like I haven't found a name I really like, just like you do. Also, I'd like to ask if we can use abbreviations in our names, like FD or Fd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3347051762
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [74.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "julianhyde (via GitHub)" <gi...@apache.org>.
julianhyde commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3349582994
@mihaibudiu This could be a nice piece of library code if approached as some kind of collection class. But the javadoc doesn't doesn't define any terms, and does not give any examples. So it's impenetrable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3351367070
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [74.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3347372890
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4561&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4561&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [74.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4561&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7205] Implement Core FD Algorithm Library for Functional Dependencies [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on PR #4561:
URL: https://github.com/apache/calcite/pull/4561#issuecomment-3347371499
I have temporarily created a separate `FunctionalDependenciesTest` to demonstrate the test, which is very convenient for development verification and will be moved to `RelMetadataTest` later because I am not sure whether this version will be approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org