You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/08 03:15:04 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38422: [SPARK-40948][SQL] Introduce new error class: PATH_NOT_FOUND

HyukjinKwon commented on code in PR #38422:
URL: https://github.com/apache/spark/pull/38422#discussion_r1016103408


##########
R/pkg/tests/fulltests/test_sparkSQL.R:
##########
@@ -3990,12 +3990,21 @@ test_that("Call DataFrameWriter.load() API in Java without path and check argume
   expect_error(read.df(source = "json"),
                paste("Error in load : analysis error - Unable to infer schema for JSON.",
                      "It must be specified manually"))
-  expect_error(read.df("arbitrary_path"), "Error in load : analysis error - Path does not exist")
-  expect_error(read.json("arbitrary_path"), "Error in json : analysis error - Path does not exist")
-  expect_error(read.text("arbitrary_path"), "Error in text : analysis error - Path does not exist")
-  expect_error(read.orc("arbitrary_path"), "Error in orc : analysis error - Path does not exist")
+  expect_error(read.df("arbitrary_path"),
+               paste("Error in load : analysis error - [PATH_NOT_FOUND] Path does not exist:",
+                     "file:/__w/spark/spark/arbitrary_path."), fixed = TRUE)

Review Comment:
   @itholic can we avoid checking the exact path matching here? If we run the tests in other environmetns, they will always file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org