[jira] [Commented] (OAK-3449) DocumentNodeStore support for predefined clusterIds should use ClusterNodeInfos

["Stefan Egli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14943031#comment-14943031 ] 

Stefan Egli commented on OAK-3449:
----------------------------------

Would that mean the instanceId can be set on the builder and the DocumentNodeStore passes it to the ClusterNodeInfo? That would be useful (also for fixing OAK-3471)

> DocumentNodeStore support for predefined clusterIds should use ClusterNodeInfos
> -------------------------------------------------------------------------------
>
>                 Key: OAK-3449
>                 URL: https://issues.apache.org/jira/browse/OAK-3449
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, mongomk, rdbmk
>    Affects Versions: 1.0.21, 1.3.6, 1.2.6
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>              Labels: test
>         Attachments: OAK-3449.diff, cid.diff
>
>
> We currently support explicit assignment of clusterId (builder.setClusterId()). In this case, DocumentNodeStore uses the specified cluster id and skips all code related to creating/maintaining ClusterNodeInfos.
> This feature is mainly (only?) used for testing (mainly allowing multiple instances to run from the same machine/instance combination). This works, but causes the logic related to ClusterNodeInfo not to be used at all (for instance, LastRevRecovery).
> So we ought to change this config option to use ClusterNodeInfo in a way that is at least similar to real-world use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)