[GitHub] [iceberg] Fokko commented on a diff in pull request #6146: Build: Enable revapi on core/parquet/orc/common/data modules

[GitBox <gi...@apache.org>]

Fokko commented on code in PR #6146:
URL: https://github.com/apache/iceberg/pull/6146#discussion_r1017125840


##########
build.gradle:
##########
@@ -91,6 +91,7 @@ dependencyRecommendations {
 }
 
 def projectVersion = getProjectVersion()
+final REVAPI_PREOJECTS = ["iceberg-api", "iceberg-core", "iceberg-parquet", "iceberg-orc", "iceberg-common", "iceberg-data"]

Review Comment:
   ```suggestion
   final REVAPI_PROJECTS = ["iceberg-api", "iceberg-core", "iceberg-parquet", "iceberg-orc", "iceberg-common", "iceberg-data"]
   ```



##########
build.gradle:
##########
@@ -105,6 +106,16 @@ subprojects {
   apply plugin: 'nebula.dependency-recommender'
   apply plugin: 'java-library'
 
+  if (project.name in REVAPI_PREOJECTS) {

Review Comment:
   ```suggestion
     if (project.name in REVAPI_PROJECTS) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org