You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/06 03:29:32 UTC
[GitHub] [superset] betodealmeida opened a new pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
betodealmeida opened a new pull request #13960:
URL: https://github.com/apache/superset/pull/13960
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR is a first step in making the v1 API compatible with [SIP-40](https://github.com/apache/superset/issues/9194) and [SIP-41](https://github.com/apache/superset/issues/9298).
Currently, the API returns exceptions using helper methods from Flask-AppBuilder, eg:
```python
try:
TestConnectionDatabaseCommand(g.user, item).run()
return self.response(200, message="OK")
except DatabaseTestConnectionFailedError as ex:
return self.response_422(message=str(ex))
except SupersetErrorException as ex:
return self.response(ex.status, message=ex.error.message)
```
These responses are simple JSON payloads, not compatible with the standard error format introduced in SIP-40. For example, when adding a database with a non-existent driver (`foo://`) this is returned:
```json
{"message": "Could not load database driver: BaseEngineSpec"}
```
And this is the message displayed in the frontend (in a toast):
> ERROR: Could not load database driver: BaseEngineSpec
To conform with SIP-41 I added a new decorator called `handle_exception` that captures exceptions and formats them according to SIP-40. This allows us to simplify the API logic, removing the need to capture exceptions when running commands (see the new `test_connection` method in this PR).
With the decorator, the backend now returns:
```json
{
"errors": [
{
"message": "Could not load database driver: BaseEngineSpec",
"error_type": "GENERIC_COMMAND_ERROR",
"level": "error",
"extra": {
"issue_codes": [
{
"code": 1010,
"message": "Issue 1010 - Superset found an error while running a command."
}
]
}
}
]
}
```
And the message is displayed correctly in the frontend as before, in a toast, without requiring any modifications:
> ERROR: Could not load database driver: BaseEngineSpec
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
See above.
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Will add unit tests, I wanted to discuss this first.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/superset/issues/11882
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar removed a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
dpgaspar removed a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813939738
Sometime ago @john-bodley proposed to use this `Flask` capability: https://flask.palletsprojects.com/en/1.1.x/errorhandling/#registering. I like the idea, and it seems doable, that way we would not need to implement our own decorator for error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.27%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head d77fe8b. Consider uploading reports for the commit d77fe8b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.64% +0.27%
==========================================
Files 935 935
Lines 47375 47375
Branches 5973 5973
==========================================
+ Hits 37131 37260 +129
+ Misses 10097 9972 -125
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+2.24%)` | :arrow_up: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...d77fe8b](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.27%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head f7caae7. Consider uploading reports for the commit f7caae7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.64% +0.27%
==========================================
Files 935 935
Lines 47375 47375
Branches 5973 5973
==========================================
+ Hits 37131 37260 +129
+ Misses 10097 9972 -125
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+2.24%)` | :arrow_up: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...f7caae7](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.07%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.45% +0.07%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37192 +61
+ Misses 10097 10072 -25
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.27%)` | :arrow_up: |
| hive | `?` | |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.00%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `1.59%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 76.77% -1.60%
==========================================
Files 935 936 +1
Lines 47375 47406 +31
Branches 5973 5956 -17
==========================================
- Hits 37131 36398 -733
- Misses 10097 10838 +741
- Partials 147 170 +23
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `44.17% <0.00%> (-9.63%)` | :arrow_down: |
| hive | `?` | |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.00%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `63.38% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `57.57% <100.00%> (-21.97%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [107 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (46284f3) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.06%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 46284f3 differs from pull request most recent head 37ee273. Consider uploading reports for the commit 37ee273 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.43% +0.06%
==========================================
Files 935 938 +3
Lines 47375 47579 +204
Branches 5973 6013 +40
==========================================
+ Hits 37131 37320 +189
- Misses 10097 10116 +19
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <69.56%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...37ee273](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-814251319
> Sometime ago @john-bodley proposed to use this Flask capability: https://flask.palletsprojects.com/en/1.1.x/errorhandling/#registering. I like the idea, and it seems doable, that way we would not need to implement our own decorator for error handling
I agree, I love that pattern. Let me give it a try, it might be easier since we register the error handler and then we can gradually change the APIs to raise `SupersetErrorException` and `SupersetErrorsException` (or `ComandException` initially, but I'd rather have all APIs only returning one of the first two).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813822057
> So in this case, you've got the `DatabaseTestConnectionFailedError` that `test_connection` can raise. Should this be something that extends a `SupersetErrorException` or should it be caught in the `handle_exception` wrapper and then return a response with a constructed SupersetError of type `TEST_CONNECTION_PORT_CLOSED_ERROR` or `TEST_CONNECTION_HOST_DOWN_ERROR`?
Right, I actually have another PR where I started doing that:
```python
class DatabaseTestConnectionFailedError(SupersetErrorsException):
message = _("Connection failed, please check your connection settings")
```
This way it will expose the proper errors (and additional errors that I'm adding, eg, `TEST_CONNECTION_INVALID_USERNAME_ERROR`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (b5bac58) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.87%`.
> The diff coverage is `84.74%`.
> :exclamation: Current head b5bac58 differs from pull request most recent head 273667f. Consider uploading reports for the commit 273667f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 77.50% -0.88%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
- Hits 37131 36718 -413
- Misses 10097 10497 +400
- Partials 147 159 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `48.49% <100.00%> (-5.30%)` | :arrow_down: |
| hive | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <73.33%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <90.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `63.38% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (ø)` | |
| ... and [101 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...273667f](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.27%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head d49b790. Consider uploading reports for the commit d49b790 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.64% +0.27%
==========================================
Files 935 935
Lines 47375 47375
Branches 5973 5973
==========================================
+ Hits 37131 37260 +129
+ Misses 10097 9972 -125
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+2.24%)` | :arrow_up: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...d49b790](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (7afcde9) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `83.92%`.
> :exclamation: Current head 7afcde9 differs from pull request most recent head 273667f. Consider uploading reports for the commit 273667f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <100.00%> (+2.25%)` | :arrow_up: |
| hive | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <72.41%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...273667f](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (46284f3) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.06%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 46284f3 differs from pull request most recent head cded967. Consider uploading reports for the commit cded967 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.43% +0.06%
==========================================
Files 935 938 +3
Lines 47375 47579 +204
Branches 5973 6013 +40
==========================================
+ Hits 37131 37320 +189
- Misses 10097 10116 +19
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <69.56%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...cded967](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608154010
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -113,3 +113,21 @@ The host might be down, and cannot be reached on the provided port.
The host provided when adding a new database doesn't seem to be up.
Additionally, it cannot be reached on the provided port. Please check that
there are no firewall rules preventing access to the host.
+
+## Issue 1010
+
+```
+Superset found an error while running a command.
+```
+
+Something unexpected happened, and Superset encountered an error while
+running a command. Please reach out to your administrator.
+
+## Issue 1011
+
+```
+Superset found an unexpected error.
Review comment:
nit: i prefer `encountered` here to `found` (the github suggestions broke here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.23%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.61% +0.23%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37269 +138
+ Misses 10097 9995 -102
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.27%)` | :arrow_up: |
| hive | `80.27% <84.00%> (+<0.01%)` | :arrow_up: |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <84.00%> (-0.16%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.32% <100.00%> (-1.45%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.32%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.70% +0.32%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37310 +179
+ Misses 10097 9954 -143
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.27%)` | :arrow_up: |
| hive | `80.27% <84.00%> (+<0.01%)` | :arrow_up: |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `80.29% <84.00%> (+<0.01%)` | :arrow_up: |
| python | `81.15% <84.00%> (+<0.01%)` | :arrow_up: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.76% <100.00%> (-0.02%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608289439
##########
File path: tests/databases/api_tests.py
##########
@@ -820,7 +820,21 @@ def test_test_connection_failed(self):
self.assertEqual(rv.headers["Content-Type"], "application/json; charset=utf-8")
response = json.loads(rv.data.decode("utf-8"))
expected_response = {
- "message": "Could not load database driver: BaseEngineSpec",
+ "errors": [
+ {
+ "message": "Could not load database driver: BaseEngineSpec",
Review comment:
Right, we're going to work on all the messaging in the test connection flow and add database flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (7afcde9) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `83.92%`.
> :exclamation: Current head 7afcde9 differs from pull request most recent head 0946cfe. Consider uploading reports for the commit 0946cfe to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <100.00%> (+2.25%)` | :arrow_up: |
| hive | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <72.41%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...0946cfe](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.68%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head f7caae7. Consider uploading reports for the commit f7caae7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 77.69% -0.69%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5973
==========================================
- Hits 37131 36805 -326
- Misses 10097 10411 +314
- Partials 147 158 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.05% <ø> (-3.74%)` | :arrow_down: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...f7caae7](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #13960:
URL: https://github.com/apache/superset/pull/13960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.06%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.44% +0.06%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37189 +58
+ Misses 10097 10075 -22
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.68% <84.00%> (-0.46%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [33 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.04%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.42% +0.04%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37179 +48
+ Misses 10097 10085 -12
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.64% <84.00%> (-0.50%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.08% <100.00%> (-1.69%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [35 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (46284f3) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.06%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 46284f3 differs from pull request most recent head 6cfd49c. Consider uploading reports for the commit 6cfd49c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.43% +0.06%
==========================================
Files 935 938 +3
Lines 47375 47579 +204
Branches 5973 6013 +40
==========================================
+ Hits 37131 37320 +189
- Misses 10097 10116 +19
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <69.56%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...6cfd49c](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (050361a) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.20%`.
> The diff coverage is `83.92%`.
> :exclamation: Current head 050361a differs from pull request most recent head 6cfd49c. Consider uploading reports for the commit 6cfd49c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 78.17% -0.21%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
- Hits 37131 37033 -98
- Misses 10097 10180 +83
- Partials 147 161 +14
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.70% <100.00%> (-0.09%)` | :arrow_down: |
| hive | `?` | |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <72.41%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [42 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...6cfd49c](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.20%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 78.16% -0.21%
==========================================
Files 935 936 +1
Lines 47375 47380 +5
Branches 5973 5956 -17
==========================================
- Hits 37131 37036 -95
- Misses 10097 10201 +104
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `80.16% <84.00%> (-0.98%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.07% <100.00%> (-1.71%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `86.47% <100.00%> (-5.56%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [57 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r607640450
##########
File path: superset/views/base_api.py
##########
@@ -84,6 +88,72 @@ def wraps(self: "BaseSupersetModelRestApi", *args: Any, **kwargs: Any) -> Respon
return functools.update_wrapper(wraps, f)
+def get_level(status: int) -> ErrorLevel:
+ if status < 400:
+ return ErrorLevel.INFO
+ if status < 500:
+ return ErrorLevel.WARNING
+ return ErrorLevel.ERROR
+
+
+def handle_exception(f: Callable[..., FlaskResponse]) -> Callable[..., FlaskResponse]:
+ """
+ A decorator that formats exceptions.
+
+ SIP-40 (https://github.com/apache/superset/issues/9194) introduced
+ a standard error payload for all API errors returned by Superset.
+ This decorator formats exceptions to conform to it.
+ """
+
+ def wraps(self: Any, *args: Any, **kwargs: Any) -> FlaskResponse:
+ try:
+ return f(self, *args, **kwargs)
+ except SupersetErrorException as ex:
+ logger.warning(ex)
+ return json_errors_response(errors=[ex.error], status=ex.status)
+ except SupersetErrorsException as ex:
+ logger.warning(ex)
+ return json_errors_response(errors=ex.errors, status=ex.status)
+ except CommandInvalidError as ex:
+ logger.warning(ex)
+ return json_errors_response(
+ errors=[
+ SupersetError(
Review comment:
Are we always going to throw HTTP 500 on these? would it make sense that the exception itself could identify the HTTP status code?
##########
File path: superset/databases/api.py
##########
@@ -604,13 +609,8 @@ def test_connection( # pylint: disable=too-many-return-statements
# This validates custom Schema with custom validations
except ValidationError as error:
return self.response_400(message=error.messages)
- try:
- TestConnectionDatabaseCommand(g.user, item).run()
- return self.response(200, message="OK")
- except DatabaseTestConnectionFailedError as ex:
- return self.response_422(message=str(ex))
- except SupersetErrorException as ex:
- return self.response(ex.status, message=ex.error.message)
+ TestConnectionDatabaseCommand(g.user, item).run()
+ return self.response(200, message="OK")
Review comment:
the OpenAPI error responses are not correct now, on the `BaseSupersetModelRestApi` we can declare the new SIP-40 schema https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/api/__init__.py#L296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.27%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head c11d9d1. Consider uploading reports for the commit c11d9d1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.64% +0.27%
==========================================
Files 935 935
Lines 47375 47375
Branches 5973 5973
==========================================
+ Hits 37131 37260 +129
+ Misses 10097 9972 -125
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+2.24%)` | :arrow_up: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...c11d9d1](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (b5bac58) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `84.74%`.
> :exclamation: Current head b5bac58 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| hive | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <73.33%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <90.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.27%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head cded967. Consider uploading reports for the commit cded967 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.64% +0.27%
==========================================
Files 935 935
Lines 47375 47375
Branches 5973 5973
==========================================
+ Hits 37131 37260 +129
+ Misses 10097 9972 -125
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <ø> (+2.24%)` | :arrow_up: |
| javascript | `67.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| ... and [18 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...cded967](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r607985491
##########
File path: superset/databases/api.py
##########
@@ -604,13 +609,8 @@ def test_connection( # pylint: disable=too-many-return-statements
# This validates custom Schema with custom validations
except ValidationError as error:
return self.response_400(message=error.messages)
- try:
- TestConnectionDatabaseCommand(g.user, item).run()
- return self.response(200, message="OK")
- except DatabaseTestConnectionFailedError as ex:
- return self.response_422(message=str(ex))
- except SupersetErrorException as ex:
- return self.response(ex.status, message=ex.error.message)
+ TestConnectionDatabaseCommand(g.user, item).run()
+ return self.response(200, message="OK")
Review comment:
Good catch, I'll fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (70e4c0f) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.68%`.
> The diff coverage is `97.36%`.
> :exclamation: Current head 70e4c0f differs from pull request most recent head f7caae7. Consider uploading reports for the commit f7caae7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 77.69% -0.69%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5973
==========================================
- Hits 37131 36805 -326
- Misses 10097 10411 +314
- Partials 147 158 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.05% <ø> (-3.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <95.45%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...f7caae7](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (b5bac58) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `84.74%`.
> :exclamation: Current head b5bac58 differs from pull request most recent head 273667f. Consider uploading reports for the commit 273667f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| hive | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <73.33%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <90.00%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.18% <100.00%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...273667f](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608154010
##########
File path: docs/src/pages/docs/Miscellaneous/issue_codes.mdx
##########
@@ -113,3 +113,21 @@ The host might be down, and cannot be reached on the provided port.
The host provided when adding a new database doesn't seem to be up.
Additionally, it cannot be reached on the provided port. Please check that
there are no firewall rules preventing access to the host.
+
+## Issue 1010
+
+```
+Superset found an error while running a command.
+```
+
+Something unexpected happened, and Superset encountered an error while
+running a command. Please reach out to your administrator.
+
+## Issue 1011
+
+```
+Superset found an unexpected error.
Review comment:
nit: i prefer `encountered` here to `found`
```suggestion
Superset encountered an error while running a command.
```
Something unexpected happened, and Superset encountered an error while
running a command. Please reach out to your administrator.
## Issue 1011
```
Superset encountered an unexpected error.
```
##########
File path: superset/errors.py
##########
@@ -135,6 +139,20 @@ class SupersetErrorType(str, Enum):
),
},
],
+ SupersetErrorType.GENERIC_COMMAND_ERROR: [
+ {
+ "code": 1010,
+ "message": _(
+ "Issue 1010 - Superset found an error while running a command."
+ ),
+ },
+ ],
+ SupersetErrorType.GENERIC_BACKEND_ERROR: [
+ {
+ "code": 1011,
+ "message": _("Issue 1011 - Superset found an unexpected error."),
Review comment:
same comment here
```suggestion
"Issue 1010 - Superset encountered an error while running a command."
),
},
],
SupersetErrorType.GENERIC_BACKEND_ERROR: [
{
"code": 1011,
"message": _("Issue 1011 - Superset encountered an unexpected error."),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (050361a) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `83.92%`.
> :exclamation: Current head 050361a differs from pull request most recent head 6cfd49c. Consider uploading reports for the commit 6cfd49c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <72.41%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...6cfd49c](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608271456
##########
File path: tests/databases/api_tests.py
##########
@@ -820,7 +820,21 @@ def test_test_connection_failed(self):
self.assertEqual(rv.headers["Content-Type"], "application/json; charset=utf-8")
response = json.loads(rv.data.decode("utf-8"))
expected_response = {
- "message": "Could not load database driver: BaseEngineSpec",
+ "errors": [
+ {
+ "message": "Could not load database driver: BaseEngineSpec",
Review comment:
i guess ideally in the future these messages will become actual errors with details on how to resolve them in the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r607990331
##########
File path: superset/views/base_api.py
##########
@@ -84,6 +88,72 @@ def wraps(self: "BaseSupersetModelRestApi", *args: Any, **kwargs: Any) -> Respon
return functools.update_wrapper(wraps, f)
+def get_level(status: int) -> ErrorLevel:
+ if status < 400:
+ return ErrorLevel.INFO
+ if status < 500:
+ return ErrorLevel.WARNING
+ return ErrorLevel.ERROR
+
+
+def handle_exception(f: Callable[..., FlaskResponse]) -> Callable[..., FlaskResponse]:
+ """
+ A decorator that formats exceptions.
+
+ SIP-40 (https://github.com/apache/superset/issues/9194) introduced
+ a standard error payload for all API errors returned by Superset.
+ This decorator formats exceptions to conform to it.
+ """
+
+ def wraps(self: Any, *args: Any, **kwargs: Any) -> FlaskResponse:
+ try:
+ return f(self, *args, **kwargs)
+ except SupersetErrorException as ex:
+ logger.warning(ex)
+ return json_errors_response(errors=[ex.error], status=ex.status)
+ except SupersetErrorsException as ex:
+ logger.warning(ex)
+ return json_errors_response(errors=ex.errors, status=ex.status)
+ except CommandInvalidError as ex:
+ logger.warning(ex)
+ return json_errors_response(
+ errors=[
+ SupersetError(
Review comment:
I don't think that command exceptions should have HTTP status codes, they should care only about business logic and be decoupled from the API.
Ideally the API layer should do the mapping between command exceptions to `SupersetError(s)Exception`. The reason why I added `CommandInvalidError` and `CommandException` is so we can gradually implement that mapping, while in the meantime any non-covered command exceptions return a 500.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (0ee5033) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.23%`.
> The diff coverage is `85.18%`.
> :exclamation: Current head 0ee5033 differs from pull request most recent head a2d5833. Consider uploading reports for the commit a2d5833 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.61% +0.23%
==========================================
Files 935 936 +1
Lines 47375 47407 +32
Branches 5973 5956 -17
==========================================
+ Hits 37131 37269 +138
+ Misses 10097 9995 -102
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.27%)` | :arrow_up: |
| hive | `80.27% <84.00%> (+<0.01%)` | :arrow_up: |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
| mysql | `80.56% <84.00%> (+<0.01%)` | :arrow_up: |
| postgres | `80.60% <84.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `80.98% <84.00%> (-0.16%)` | :arrow_down: |
| sqlite | `80.16% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.66% <60.00%> (+0.05%)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.11% <78.57%> (+0.28%)` | :arrow_up: |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.32% <100.00%> (-1.45%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.80% <100.00%> (-0.23%)` | :arrow_down: |
| [superset/databases/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `93.33% <100.00%> (+0.15%)` | :arrow_up: |
| ... and [30 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...a2d5833](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (050361a) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.17%`.
> The diff coverage is `83.92%`.
> :exclamation: Current head 050361a differs from pull request most recent head 6cfd49c. Consider uploading reports for the commit 6cfd49c to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.17%
==========================================
Files 935 935
Lines 47375 47374 -1
Branches 5973 5956 -17
==========================================
+ Hits 37131 37211 +80
+ Misses 10097 10020 -77
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+2.24%)` | :arrow_up: |
| hive | `?` | |
| javascript | `67.30% <100.00%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.61% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <72.41%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `85.71% <100.00%> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `83.09% <100.00%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (-0.26%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| ... and [32 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...6cfd49c](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (46284f3) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **decrease** coverage by `0.69%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 46284f3 differs from pull request most recent head cded967. Consider uploading reports for the commit cded967 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
- Coverage 78.37% 77.67% -0.70%
==========================================
Files 935 938 +3
Lines 47375 47578 +203
Branches 5973 6013 +40
==========================================
- Hits 37131 36958 -173
- Misses 10097 10453 +356
- Partials 147 167 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.92% <100.00%> (+2.13%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <69.56%> (ø)` | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.23% <87.50%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [75 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...cded967](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813801650
# [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=h1) Report
> Merging [#13960](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=desc) (84f366b) into [master](https://codecov.io/gh/apache/superset/commit/f19f2c3ac884b270e7d9bf8629ed933b0fa98a7c?el=desc) (f19f2c3) will **increase** coverage by `0.16%`.
> The diff coverage is `81.57%`.
> :exclamation: Current head 84f366b differs from pull request most recent head cded967. Consider uploading reports for the commit cded967 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13960 +/- ##
==========================================
+ Coverage 78.37% 78.54% +0.16%
==========================================
Files 935 937 +2
Lines 47375 47442 +67
Branches 5973 5976 +3
==========================================
+ Hits 37131 37263 +132
+ Misses 10097 10036 -61
+ Partials 147 143 -4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <100.00%> (+2.27%)` | :arrow_up: |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...rBar/CascadeFilters/CascadeFilterControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVGaWx0ZXJDb250cm9sL2luZGV4LnRzeA==) | `57.14% <ø> (ø)` | |
| [.../FilterBar/CascadeFilters/CascadePopover/index.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyL2luZGV4LnRzeA==) | `80.32% <ø> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `75.83% <69.56%> (ø)` | |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <100.00%> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.03% <100.00%> (ø)` | |
| [superset/errors.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/exceptions.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `96.61% <100.00%> (ø)` | |
| [...ilters/FilterBar/CascadeFilters/CascadePopover.tsx](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nhc2NhZGVGaWx0ZXJzL0Nhc2NhZGVQb3BvdmVyLnRzeA==) | `63.38% <0.00%> (-19.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.88% <0.00%> (-5.43%)` | :arrow_down: |
| ... and [30 more](https://codecov.io/gh/apache/superset/pull/13960/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=footer). Last update [f19f2c3...cded967](https://codecov.io/gh/apache/superset/pull/13960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on pull request #13960: feat: initial work to make v1 API compatible with SIP-40 and SIP-41
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #13960:
URL: https://github.com/apache/superset/pull/13960#issuecomment-813939738
Sometime ago @john-bodley proposed to use this `Flask` capability: https://flask.palletsprojects.com/en/1.1.x/errorhandling/#registering. I like the idea, and it seems doable, that way we would not need to implement our own decorator for error handling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org