You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by sb...@apache.org on 2017/07/04 08:19:32 UTC
[09/28] ignite git commit: Code commenting after dev list questions
Code commenting after dev list questions
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/db8112fc
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/db8112fc
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/db8112fc
Branch: refs/heads/ignite-2.1.2-exchange
Commit: db8112fc67c7d539e7ce28f65669b33b38fabebc
Parents: 5037604
Author: dpavlov <dp...@gridgain.com>
Authored: Fri Jun 23 21:02:02 2017 +0300
Committer: dpavlov <dp...@gridgain.com>
Committed: Thu Jun 29 21:03:48 2017 +0300
----------------------------------------------------------------------
.../java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java | 5 +++++
.../discovery/tcp/messages/TcpDiscoveryAbstractMessage.java | 8 +++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ignite/blob/db8112fc/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
index 184b6cd..03afff5 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
@@ -3981,6 +3981,11 @@ class ServerImpl extends TcpDiscoveryImpl {
/**
* Processes node added message.
*
+ * For coordinator node method marks the messages as verified for rest of nodes to apply the
+ * changes this message is issued for.
+ *
+ * Node added message is processed by other nodes only after coordinator verification.
+ *
* @param msg Node added message.
* @deprecated Due to current protocol node add process cannot be dropped in the middle of the ring,
* if new node auth fails due to config inconsistency. So, we need to finish add
http://git-wip-us.apache.org/repos/asf/ignite/blob/db8112fc/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAbstractMessage.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAbstractMessage.java b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAbstractMessage.java
index e982b2f..a23cb63 100644
--- a/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAbstractMessage.java
+++ b/modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/messages/TcpDiscoveryAbstractMessage.java
@@ -57,7 +57,13 @@ public abstract class TcpDiscoveryAbstractMessage implements Serializable {
/** Message ID. */
private IgniteUuid id;
- /** Verifier node ID. */
+ /**
+ * Verifier node ID.
+ * Node can mark the messages as verified for rest of nodes to apply the
+ * changes this message is issued for, i.e. node added message, node failed or
+ * left message are processed by other nodes only after coordinator
+ * verification.
+ */
private UUID verifierNodeId;
/** Topology version. */