You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/09 09:00:52 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
PragmaTwice opened a new issue, #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561
The current `cmake/gtest.cmake` is confusing, especially since it contains a directory on [line 38](https://github.com/apache/incubator-kvrocks/blob/cf9901f88f5905f75e542999529fcbad2ec66dd1/cmake/gtest.cmake#L38) that does not exist, so this file does not seem to provide any functionality.
The project uses the system-supplied gtest, which makes it difficult to control its version. It also seems that the project does not use mechanisms such as `find_package` for gtest, but relies directly on the system header directory (e.g. `/usr/include` to find `gtest/gest.h`) and the `-lgtest` link option.
I think it would be better to reintroduce googletest with fixed tag/commit hash at the cmake level (source level) using `ExternalProject` or `FetchContent`. Since gtest doesn't have many translation units, it doesn't take long to compile.
I'm happy to provide PRs if that sounds like a good idea.
@tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice closed issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
PragmaTwice closed issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
URL: https://github.com/apache/incubator-kvrocks/issues/561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561#issuecomment-1120896772
@ColinChamber we can delay this PR since glog0.5 remove the autoconf which would
break the makefile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561#issuecomment-1120860717
+1, other guys also suffered this problem, I think we can reintroduce `gtest` to make the build process easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on issue #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561#issuecomment-1124645060
Solved in #564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ColinChamber commented on issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
ColinChamber commented on issue #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561#issuecomment-1120915703
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] ColinChamber commented on issue #561: [QUESTION] Consider reintroducing googletest to cmake dependencies?
Posted by GitBox <gi...@apache.org>.
ColinChamber commented on issue #561:
URL: https://github.com/apache/incubator-kvrocks/issues/561#issuecomment-1120891160
By the way could you help to finish this PR #525 ? I'm sorry I don't have the time currently. Thanks @PragmaTwice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org