You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/04/25 19:52:09 UTC
[GitHub] [incubator-iceberg] wssbck opened a new pull request #967: Update documentation for Presto
wssbck opened a new pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967
The connector is already part of the master branch of Presto SQL, although many features are still missing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on pull request #967: Update documentation for Presto SQL
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967#issuecomment-619636098
FYI @electrum, @lxynov, and @Parth-Brahmbhatt. Should we add a compatibility table for Presto here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on pull request #967: Update documentation for Presto SQL
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967#issuecomment-619636165
Thanks for updating, @wssbck! I merged this and it will be in the next deploy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #967: Update documentation for Presto SQL
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967#discussion_r415406325
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,6 @@
# Presto
-An Iceberg connector for Presto is available in [pull request #458 on prestosql/presto](https://github.com/prestosql/presto/pull/458)
+Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in its README:
+
+https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md
Review comment:
Could you use a descriptive link instead of embedding a URL? Something like this:
> Current status of the connector is detailed in the [presto-iceberg README](https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] wssbck commented on a change in pull request #967: Update documentation for Presto SQL
Posted by GitBox <gi...@apache.org>.
wssbck commented on a change in pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967#discussion_r415417846
##########
File path: site/docs/presto.md
##########
@@ -17,4 +17,6 @@
# Presto
-An Iceberg connector for Presto is available in [pull request #458 on prestosql/presto](https://github.com/prestosql/presto/pull/458)
+Iceberg connector is part of Presto SQL's master branch, although support for many features is still under development. Current status of the connector is detailed in its README:
+
+https://github.com/prestosql/presto/blob/master/presto-iceberg/README.md
Review comment:
Done :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [incubator-iceberg] electrum commented on pull request #967: Update documentation for Presto SQL
Posted by GitBox <gi...@apache.org>.
electrum commented on pull request #967:
URL: https://github.com/apache/incubator-iceberg/pull/967#issuecomment-619694447
I think this is good. Pointing at the readme will ensure it’s current. Hopefully we can finish it quickly and make fully supported and documented in Presto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org