You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/12/10 10:47:08 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #2349: Prototype/fdb layer delete attachments

iilyak commented on a change in pull request #2349: Prototype/fdb layer delete attachments
URL: https://github.com/apache/couchdb/pull/2349#discussion_r355965842
 
 

 ##########
 File path: src/fabric/src/fabric2_util.erl
 ##########
 @@ -124,6 +126,20 @@ validate_json_list_of_strings(Member, Props) ->
     end.
 
 
+hash_atts([]) ->
+    <<>>;
+
+hash_atts(Atts) ->
+    lists:sort(fun(A, B) ->
 
 Review comment:
   Am I reading it correctly we ignore the result of a lists:sort?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services