[GitHub] [couchdb] nickva commented on a diff in pull request #4629: Fix prometheus to survive mem3_sync termination

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on code in PR #4629:
URL: https://github.com/apache/couchdb/pull/4629#discussion_r1212183611


##########
src/couch_prometheus/src/couch_prometheus_server.erl:
##########
@@ -128,7 +130,14 @@ get_internal_replication_jobs_stat() ->
         internal_replication_jobs,
         gauge,
         "count of internal replication changes to process",
-        mem3_sync:get_backlog()
+        try mem3_sync:get_backlog() of

Review Comment:
   If we return directly return the result and don't match on it, I think we can just to try `mem3_sync:get_backlog() catch ...` without the `of`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org