You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "sverholen (via GitHub)" <gi...@apache.org> on 2023/04/05 22:17:26 UTC
[GitHub] [jena] sverholen opened a new pull request, #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
sverholen opened a new pull request, #1832:
URL: https://github.com/apache/jena/pull/1832
GitHub issue resolved #
Pull request Description:
----
- [ ] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [ ] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1159701725
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final Lang LANG = Lang.JSONLD11;
Review Comment:
Might as well not have this constant and have a static input of Lang.JSONLD11, and use `JSONLD11` in tests.
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final Lang LANG = Lang.JSONLD11;
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create()
+ .context(setupContext())
+ .forceLang(LANG)
Review Comment:
```suggestion
.lang(JSONLD11)
```
`lang` is sufficient. `forceLang` is only needed if the source name (URL, filename, content negoitation) gives a different answer.
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final Lang LANG = Lang.JSONLD11;
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create()
+ .context(setupContext())
+ .forceLang(LANG)
+ .fromString(CONTENT)
+ .build();
+
+ assertEquals("Custom DocumentLoader was called to handle loading", 1, TestDocumentLoader.COUNTER);
Review Comment:
Shouldn't the message be:
"Custom DocumentLoader was not called to handle loading"
The message is printed on error.
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final Lang LANG = Lang.JSONLD11;
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create()
Review Comment:
Please convert tabs to spaces. We use 4 space indent.
(Now there is github, display of files online matters a bit more)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1832:
URL: https://github.com/apache/jena/pull/1832#issuecomment-1509915546
Done with 95cb63aae81244e88ff9d2c9f4d347f62d51d46b .
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1160071155
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.jena.riot.lang;
+
+import static org.apache.jena.riot.Lang.JSONLD11;
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create().context(setupContext()).lang(JSONLD11).fromString(CONTENT).build();
Review Comment:
This does not cause a parser to run.
RDFParserBuilder.build() returns the parser, not run it.
There are some terminating actions that do run the parser.
```
@Test
public void testGetJsonLdOptions() {
StreamRDF sink = StreamRDFLib.sinkNull();
RDFParser parser = RDFParserBuilder.create()
.context(setupContext())
.lang(JSONLD11)
.fromString(CONTENT)
.build();
parser.parse(sink);
assertEquals("Custom DocumentLoader wasn't called to handle loading", 1, TestDocumentLoader.COUNTER);
}
```
Then CONTENT needs to be a valid document with an `"@context"` to trigger the document loader.
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.jena.riot.lang;
+
+import static org.apache.jena.riot.Lang.JSONLD11;
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create().context(setupContext()).lang(JSONLD11).fromString(CONTENT).build();
+
+ assertEquals("Custom DocumentLoader wasn't called to handle loading", 1, TestDocumentLoader.COUNTER);
+ }
+
+ private final Context setupContext() {
+ TestDocumentLoader loader = new TestDocumentLoader();
+ JsonLdOptions opts = new JsonLdOptions();
+
+ opts.setDocumentLoader(loader);
+
+ Context context = new Context();
+ context.set(LangJSONLD11.JSONLD_OPTIONS, opts);
+
+ return context;
+ }
+
+ private final static class TestDocumentLoader implements DocumentLoader {
+
+ public static int COUNTER = 0;
+
+ @Override
+ public Document loadDocument(URI url, DocumentLoaderOptions options) throws JsonLdError {
+ DocumentLoader loader = HttpLoader.defaultInstance();
+
+ COUNTER++;
+
+ return loader.loadDocument(url, options);
Review Comment:
Change this to return a document, does not matter what. It should work whenthe is with no network access.
```
private final static class TestDocumentLoader implements DocumentLoader {
public static int COUNTER = 0;
@Override
public Document loadDocument(URI url, DocumentLoaderOptions options) throws JsonLdError {
DocumentLoader loader = HttpLoader.defaultInstance();
JsonObject obj =
Json.createObjectBuilder()
.add("@context", JsonObject.EMPTY_JSON_OBJECT)
.build();
COUNTER++;
return JsonDocument.of(obj);
}
}
```
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.jena.riot.lang;
+
+import static org.apache.jena.riot.Lang.JSONLD11;
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final String CONTENT = "";
Review Comment:
Needs something to trigger the document loader.
```
private static final String CONTENT = "{ \"@context\": \"http://unused/\" }";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs closed pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs closed pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
URL: https://github.com/apache/jena/pull/1832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1159707822
##########
jena-arq/src/main/java/org/apache/jena/riot/lang/LangJSONLD11.java:
##########
@@ -45,13 +46,17 @@
import org.apache.jena.riot.system.ParserProfile;
import org.apache.jena.riot.system.StreamRDF;
import org.apache.jena.sparql.util.Context;
+import org.apache.jena.sparql.util.Symbol;
/**
* JSON-LD 1.1 {@link ReaderRIOT}.
*/
public class LangJSONLD11 implements ReaderRIOT {
private final ErrorHandler errorHandler;
private final ParserProfile profile;
+
+ /** value: the option object expected by JsonLdProcessor (instance of JsonLdOptions) */
+ public static final Symbol JSONLD_OPTIONS = createSymbol("JSONLD_OPTIONS");
Review Comment:
Suggestion:
`public static final Symbol JSONLD_OPTIONS = SystemARQ.allocSymbol(SYMBOLS_NS, "options");`
No need to say "jsonld" twice in the URI. `SystemARQ.allocSymbol` will do the symbol work.
Names tend to be lowercase.
##########
jena-arq/src/main/java/org/apache/jena/riot/lang/LangJSONLD11.java:
##########
@@ -178,4 +184,22 @@ else if ( k.startsWith("@") )
}
});
}
+
+ private static final String SYMBOLS_NS = "http://jena.apache.org/riot/jsonld#" ;
+ private static Symbol createSymbol(String localName) {
+ return Symbol.create(SYMBOLS_NS + localName);
+ }
+
+ /** Get the (jsonld) options from the jena context if exists or create default */
+ private static JsonLdOptions getJsonLdOptions(String baseURI, Context jenaContext) {
+ JsonLdOptions opts = null;
+ if (jenaContext != null) {
+ opts = (JsonLdOptions) jenaContext.get(JSONLD_OPTIONS);
Review Comment:
context.get wil do the casting (it's a generic function).
```
JsonLdOptions opts = jenaContext.get(JSONLD_OPTIONS);
return (opts != null) ? opts : new JsonLdOptions();
```
of an if statement if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] sverholen commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "sverholen (via GitHub)" <gi...@apache.org>.
sverholen commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1159732913
##########
jena-arq/src/main/java/org/apache/jena/riot/lang/LangJSONLD11.java:
##########
@@ -45,13 +46,17 @@
import org.apache.jena.riot.system.ParserProfile;
import org.apache.jena.riot.system.StreamRDF;
import org.apache.jena.sparql.util.Context;
+import org.apache.jena.sparql.util.Symbol;
/**
* JSON-LD 1.1 {@link ReaderRIOT}.
*/
public class LangJSONLD11 implements ReaderRIOT {
private final ErrorHandler errorHandler;
private final ParserProfile profile;
+
+ /** value: the option object expected by JsonLdProcessor (instance of JsonLdOptions) */
+ public static final Symbol JSONLD_OPTIONS = createSymbol("JSONLD_OPTIONS");
Review Comment:
Copied from LangJSONLD10. Made requested changes to that class as well.
##########
jena-arq/src/main/java/org/apache/jena/riot/lang/LangJSONLD11.java:
##########
@@ -178,4 +184,22 @@ else if ( k.startsWith("@") )
}
});
}
+
+ private static final String SYMBOLS_NS = "http://jena.apache.org/riot/jsonld#" ;
+ private static Symbol createSymbol(String localName) {
+ return Symbol.create(SYMBOLS_NS + localName);
+ }
+
+ /** Get the (jsonld) options from the jena context if exists or create default */
+ private static JsonLdOptions getJsonLdOptions(String baseURI, Context jenaContext) {
+ JsonLdOptions opts = null;
+ if (jenaContext != null) {
+ opts = (JsonLdOptions) jenaContext.get(JSONLD_OPTIONS);
Review Comment:
Copied from LangJSONLD10. Made requested changes to that class as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] sverholen commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "sverholen (via GitHub)" <gi...@apache.org>.
sverholen commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1159732119
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final Lang LANG = Lang.JSONLD11;
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create()
+ .context(setupContext())
+ .forceLang(LANG)
Review Comment:
Indeed. We tend to use forceLang because some use-cases we support do net set the correct mime type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1160071155
##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.jena.riot.lang;
+
+import static org.apache.jena.riot.Lang.JSONLD11;
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+
+ private static final String CONTENT = "";
+
+ @Test
+ public void testGetJsonLdOptions() {
+ RDFParserBuilder.create().context(setupContext()).lang(JSONLD11).fromString(CONTENT).build();
Review Comment:
This does not cause a parser to run.
RDFParserBuilder.build() returns the parser, not run it.
There are some terminating actions that do run the parser but for a clear test may be better to build then call:
```
@Test
public void testGetJsonLdOptions() {
StreamRDF sink = StreamRDFLib.sinkNull();
RDFParser parser = RDFParserBuilder.create()
.context(setupContext())
.lang(JSONLD11)
.fromString(CONTENT)
.build();
parser.parse(sink);
assertEquals("Custom DocumentLoader wasn't called to handle loading", 1, TestDocumentLoader.COUNTER);
}
```
Then CONTENT needs to be a valid document with an `"@context"` to trigger the document loader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #1832:
URL: https://github.com/apache/jena/pull/1832#issuecomment-1507426672
I need to collapse the wave function for PRs outstanding in order to prepare for the Jena 4.8.0 release. I too this PR as a diff, made the test changes, to make 95cb63aae8. Hope that's OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org