[GitHub] rdhabalia commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #2535: Add ledger op timeout to avoid topics stuck on ledger-creation
URL: https://github.com/apache/incubator-pulsar/pull/2535#discussion_r217576629
 
 

 ##########
 File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
 ##########
 @@ -56,6 +56,7 @@
     private boolean autoSkipNonRecoverableData;
     private long offloadLedgerDeletionLagMs = TimeUnit.HOURS.toMillis(4);
     private long offloadAutoTriggerSizeThresholdBytes = -1;
+    private long opTimeoutSec = 5 * 60; //5 minutes
 
 Review comment:
   sure, let me rename it. 
   
   > Also, the default in ServiceConfiguration seems to be 60sec
   Sure, I can make it 60 sec but in this PR, default time we are setting as `ZooKeeperSessionTimeout (default 30sec) *2` as it mainly happens when zk-client fails to complete callback when zk leader restarts. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services