You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/02/25 09:26:03 UTC
[GitHub] [curator] martin-g opened a new pull request #407: Fix Github Actions by adding 'distribution' for JDK setup step
martin-g opened a new pull request #407:
URL: https://github.com/apache/curator/pull/407
Merge the two workflows into one and use strategy.matrix for the Java
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] martin-g closed pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
martin-g closed pull request #407:
URL: https://github.com/apache/curator/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #407: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1050687580
@nicoloboschi do you mind taking a look here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli merged pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #407:
URL: https://github.com/apache/curator/pull/407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1051005034
Maybe if you remove the jdk17 part and we see ci passing we can merge this pr and unblock the pipeline
Does it sound like a good plan to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1051068899
Then we can commit your fix to the test and add back 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] martin-g commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1051074971
OK. The last commit is reverted!
I will create a new PR for it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] martin-g commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1051064889
We need #409 to be merged to see green build for JDK 1.8 and 11.
I'll comment out 17!
On Fri, Feb 25, 2022, 18:31 Enrico Olivelli ***@***.***>
wrote:
> Maybe if you remove the jdk17 part and we see ci passing we can merge this
> pr and unblock the pipeline
>
> Does it sound like a good plan to you?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/curator/pull/407#issuecomment-1051005034>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABYUQTYSAPVRJRRZZKMZCLU46VGRANCNFSM5PJX3F3Q>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1051068712
Let's remove jdk17 stuff and merge this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] eolivelli commented on pull request #407: CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1050974774
> It seems with one additional minor change (upgrade Mockito-core to 4.3.1) and few import fixes the build will pass with JDK 17 too.
> Do you want me to do it in this PR ?
this would be great, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] martin-g commented on pull request #407: Fix Github Actions by adding 'distribution' for JDK setup step
Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #407:
URL: https://github.com/apache/curator/pull/407#issuecomment-1050744375
I guess the test failures are expected.
At least the CI setup now works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org