You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2023/04/24 09:03:44 UTC
[GitHub] [doris] Mryange opened a new pull request, #19002: [refactor] Do not let "set enable_vectorized_engine=true" throw an error.
Mryange opened a new pull request, #19002:
URL: https://github.com/apache/doris/pull/19002
# Proposed changes
In this pr https://github.com/apache/doris/pull/18166 remove environment variable enable_vectorized_engine,it makes
```
mysql [(none)]>set enable_vectorized_engine=true;
ERROR 1228 (HY000): errCode = 2, detailMessage = Unknown system variable 'enable_vectorized_engine'
```
This might be too radical , users could upgrade from older versions without modifying corresponding SQL statements.
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1520976173
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19002:
URL: https://github.com/apache/doris/pull/19002#discussion_r1175949355
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -532,6 +534,8 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = EXTRACT_WIDE_RANGE_EXPR, needForward = true)
public boolean extractWideRangeExpr = true;
+ @VariableMgr.VarAttr(name = ENABLE_VECTORIZED_ENGINE)
Review Comment:
Nothing changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1522573048
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1521049067
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #19002:
URL: https://github.com/apache/doris/pull/19002#discussion_r1175928995
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -532,6 +534,8 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = EXTRACT_WIDE_RANGE_EXPR, needForward = true)
public boolean extractWideRangeExpr = true;
+ @VariableMgr.VarAttr(name = ENABLE_VECTORIZED_ENGINE)
Review Comment:
```suggestion
@VariableMgr.VarAttr(name = ENABLE_VECTORIZED_ENGINE, expType = ExperimentalType.EXPERIMENTAL_ONLINE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #19002: [refactor] Do not let set enable_vectorized_engine=true throw an error
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1520077061
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1521162479
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1521617358
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #19002:
URL: https://github.com/apache/doris/pull/19002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19002: [refactor] Do not let set enable_vectorized_engine=true throw an error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1520078056
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1521064453
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Mryange commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1520912456
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on code in PR #19002:
URL: https://github.com/apache/doris/pull/19002#discussion_r1175954669
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -532,6 +534,8 @@ public class SessionVariable implements Serializable, Writable {
@VariableMgr.VarAttr(name = EXTRACT_WIDE_RANGE_EXPR, needForward = true)
public boolean extractWideRangeExpr = true;
+ @VariableMgr.VarAttr(name = ENABLE_VECTORIZED_ENGINE)
Review Comment:
@morningman Why it's EXPERIMENTAL_ONLINE? Should we add another expType `DEPRACATED` and mark this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19002: [refactor] Do not let set enable_vectorized_engine=true throw an error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1520078113
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19002: [refactor](config) Do not let set enable_vectorized_engine throw an error
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19002:
URL: https://github.com/apache/doris/pull/19002#issuecomment-1521903340
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org