You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 05:10:46 UTC

[GitHub] [incubator-superset] mistercrunch commented on pull request #11002: fix: revert #10455 to fix the Timer component

mistercrunch commented on pull request #11002:
URL: https://github.com/apache/incubator-superset/pull/11002#issuecomment-697137570


   +1 on @nytai 's points. We have to find a balance between switching the latest/greatest trend and sticking with patterns that work and are consistent. So many bandwagons and reasons to "rewrite all the things".
   
   I don't see anything wrong with a nice class component that works nicely. If it's not broken don't fix it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org