You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@training.apache.org by Justin Mclean <ju...@classsoftware.com> on 2020/01/24 02:20:54 UTC
build failing
Hi,
The tools dir build currently fails with:
[ERROR] Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.4.1:wget (install-asciidoctor-revealjs) on project presentation-template: Execution install-asciidoctor-revealjs of goal com.googlecode.maven-download-plugin:download-maven-plugin:1.4.1:wget failed: java.lang.ClassNotFoundException: com.googlecode.download.maven.plugin.internal.CachedFileEntry -> [Help 1]
I guess something has changed where it gett8ing reveal JS from?
Thanks,
Justin
Re: build failing
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Did you happen to dial up rat at teh same time? I’m now getting failures because README.md doesn’t have a license header.
Thanks,
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Justin,
I just pushed a change that gets rid of this problem completely.
I removed the rename plugin and added an embedded groovy script ...
should now work fine no matter how you name the files.
Chris
Am 25.01.20, 10:06 schrieb "Justin Mclean" <ju...@me.com.INVALID>:
Hi,
That unfortunate as I for instance have both index_en and index_cn in some of my presentations.
In general how does it handle multiple file? As I also have several presentation with those as well which are included by index.
Thanks,
Justin
Re: build failing
Posted by Justin Mclean <ju...@me.com.INVALID>.
Hi,
That unfortunate as I for instance have both index_en and index_cn in some of my presentations.
In general how does it handle multiple file? As I also have several presentation with those as well which are included by index.
Thanks,
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Ah ... ok ... now I know what was going on ...
If I put in the renaming in the parent, the build of the parent will fail because the file is obviously not there.
So I put it in a self-activating profile, to activate the renaming, only if the file exists.
Unfortunately activation of profiles happens before the pom is "alive" so there is no wildcards and no properties that we can use.
So I fixed things to the "index" name ... but it doesn't work for any other name and then you need to add the renaming yourself.
Think we better come up with a different/better solution ...
Chris
Am 25.01.20, 09:33 schrieb "Christofer Dutz" <ch...@c-ware.de>:
But the idea with the main.content.file is not bad ...
Could adjust the archetype and the parent pom accordingly.
Chris
Am 25.01.20, 08:44 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> I used the template to create several presentations and didn't have that issue.
Is it assuming that it is called index rather than what is specified?
For example:
<properties>
<project.main.contentfile>index_en</project.main.contentfile>
</properties>
Thanks.
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
But the idea with the main.content.file is not bad ...
Could adjust the archetype and the parent pom accordingly.
Chris
Am 25.01.20, 08:44 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> I used the template to create several presentations and didn't have that issue.
Is it assuming that it is called index rather than what is specified?
For example:
<properties>
<project.main.contentfile>index_en</project.main.contentfile>
</properties>
Thanks.
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Justin,
there's a self-activating profile in there that renames the output if the source is called "index.adoc"
So if you rename that, it will not automatically rename the output.
<!--
This plugin fails the build if there is no index.adoc file,
so only run it if there is input for generating slide output.
-->
<profiles>
<profile>
<id>rename-output</id>
<activation>
<file>
<exists>src/main/asciidoc/index.adoc</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.coderplus.maven.plugins</groupId>
<artifactId>copy-rename-maven-plugin</artifactId>
<version>${copy-rename-maven-plugin.version}</version>
<executions>
<execution>
<id>rename-slide-file</id>
<phase>process-resources</phase>
<goals>
<goal>rename</goal>
</goals>
<configuration>
<sourceFile>${project.slides.directory}/${project.main.contentfile}.revealjs</sourceFile>
<destinationFile>${project.slides.directory}/${project.main.contentfile}.html</destinationFile>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
If we want different naming schemes, then we need to adjust the tooling.
Chris
Am 25.01.20, 08:44 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
> I used the template to create several presentations and didn't have that issue.
Is it assuming that it is called index rather than what is specified?
For example:
<properties>
<project.main.contentfile>index_en</project.main.contentfile>
</properties>
Thanks.
Justin
Re: build failing
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I used the template to create several presentations and didn't have that issue.
Is it assuming that it is called index rather than what is specified?
For example:
<properties>
<project.main.contentfile>index_en</project.main.contentfile>
</properties>
Thanks.
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
That's strange,
I used the template to create several presentations and didn't have that issue.
Will investigate,
Chris
________________________________
Von: Justin Mclean <ju...@classsoftware.com>
Gesendet: Samstag, 25. Januar 2020 00:31
An: dev@training.apache.org <de...@training.apache.org>
Betreff: Re: build failing
Hi,
One thing I did notice is that it not renaming the .revealjs file and I still have to do this:
<plugin>
<groupId>com.coderplus.maven.plugins</groupId>
<artifactId>copy-rename-maven-plugin</artifactId>
<version>1.0</version>
<executions>
<execution>
<id>rename-slide-file</id>
<phase>process-resources</phase>
<goals>
<goal>rename</goal>
</goals>
<configuration>
<sourceFile>${project.slides.directory}/${project.main.contentfile}.revealjs</sourceFile>
<destinationFile>${project.slides.directory}/${project.main.contentfile}.html</destinationFile>
</configuration>
</execution>
</executions>
</plugin>
Thanks,
Justin
Re: build failing
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
One thing I did notice is that it not renaming the .revealjs file and I still have to do this:
<plugin>
<groupId>com.coderplus.maven.plugins</groupId>
<artifactId>copy-rename-maven-plugin</artifactId>
<version>1.0</version>
<executions>
<execution>
<id>rename-slide-file</id>
<phase>process-resources</phase>
<goals>
<goal>rename</goal>
</goals>
<configuration>
<sourceFile>${project.slides.directory}/${project.main.contentfile}.revealjs</sourceFile>
<destinationFile>${project.slides.directory}/${project.main.contentfile}.html</destinationFile>
</configuration>
</execution>
</executions>
</plugin>
Thanks,
Justin
Re: build failing
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> ok ... so it seems that the maven archetype plugin doesn't like fetching SNAPSHOT archetypes :-/ ... I added a super-condensed documentation how to clone and build the tooling locally and then to generate a new presentation.
I gave it a try and it’s all working nicely. Thanks!
Justin
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,
ok ... so it seems that the maven archetype plugin doesn't like fetching SNAPSHOT archetypes :-/ ... I added a super-condensed documentation how to clone and build the tooling locally and then to generate a new presentation.
Chris
Am 24.01.20, 10:15 schrieb "Christofer Dutz" <ch...@c-ware.de>:
Ok
So I "fixed" the problem even if I think it wasn't really a "problem".
The issue was, if you run "mvn site" on the root ... while I added the root pom to sort of glue together all the different parts, it should actually not be required as the project consists of multiple sub-projects within one repo.
The issue now was that therefore the intermediate pom-artifacts didn't have parent poms set. Therefore the defaults of maven were used and these seem to have issues. I fixed the problem by correctly having all artifacts have parent pom chains that end at the apache parent pom.
While I was at it I updated the parent poms of the live artifacts (not the released presentations) to the freshly released version 22.
Also did I add a small "getting started" page in the user-space of the website to explain how to use the new tooling.
Chris
PS: Just noticed I need to update the documentation on how to add the apache snapshot repo to maven as long as we haven't released the tooling.
Am 24.01.20, 10:08 schrieb "Sönke Liebau" <so...@opencore.com.INVALID>:
Thanks Chris!
On Fri, 24 Jan 2020 at 10:02, Christofer Dutz <ch...@c-ware.de>
wrote:
> Just noticed ...
>
> the problem is not when building the project (mvn clean package) but when
> building the site ... will investigate.
>
> Chris
>
> Am 24.01.20, 09:40 schrieb "Christofer Dutz" <ch...@c-ware.de>:
>
> Argh ... just read this.
>
> I just built everything with an empty repo and it worked without any
> problems.
>
> Chris
>
>
>
> Am 24.01.20, 03:42 schrieb "Justin Mclean" <ju...@classsoftware.com>:
>
> Hi,
>
> Never mind I managed to sort it out.
>
> Thanks,
> Just
>
>
>
>
>
--
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok
So I "fixed" the problem even if I think it wasn't really a "problem".
The issue was, if you run "mvn site" on the root ... while I added the root pom to sort of glue together all the different parts, it should actually not be required as the project consists of multiple sub-projects within one repo.
The issue now was that therefore the intermediate pom-artifacts didn't have parent poms set. Therefore the defaults of maven were used and these seem to have issues. I fixed the problem by correctly having all artifacts have parent pom chains that end at the apache parent pom.
While I was at it I updated the parent poms of the live artifacts (not the released presentations) to the freshly released version 22.
Also did I add a small "getting started" page in the user-space of the website to explain how to use the new tooling.
Chris
PS: Just noticed I need to update the documentation on how to add the apache snapshot repo to maven as long as we haven't released the tooling.
Am 24.01.20, 10:08 schrieb "Sönke Liebau" <so...@opencore.com.INVALID>:
Thanks Chris!
On Fri, 24 Jan 2020 at 10:02, Christofer Dutz <ch...@c-ware.de>
wrote:
> Just noticed ...
>
> the problem is not when building the project (mvn clean package) but when
> building the site ... will investigate.
>
> Chris
>
> Am 24.01.20, 09:40 schrieb "Christofer Dutz" <ch...@c-ware.de>:
>
> Argh ... just read this.
>
> I just built everything with an empty repo and it worked without any
> problems.
>
> Chris
>
>
>
> Am 24.01.20, 03:42 schrieb "Justin Mclean" <ju...@classsoftware.com>:
>
> Hi,
>
> Never mind I managed to sort it out.
>
> Thanks,
> Just
>
>
>
>
>
--
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
Re: build failing
Posted by Sönke Liebau <so...@opencore.com.INVALID>.
Thanks Chris!
On Fri, 24 Jan 2020 at 10:02, Christofer Dutz <ch...@c-ware.de>
wrote:
> Just noticed ...
>
> the problem is not when building the project (mvn clean package) but when
> building the site ... will investigate.
>
> Chris
>
> Am 24.01.20, 09:40 schrieb "Christofer Dutz" <ch...@c-ware.de>:
>
> Argh ... just read this.
>
> I just built everything with an empty repo and it worked without any
> problems.
>
> Chris
>
>
>
> Am 24.01.20, 03:42 schrieb "Justin Mclean" <ju...@classsoftware.com>:
>
> Hi,
>
> Never mind I managed to sort it out.
>
> Thanks,
> Just
>
>
>
>
>
--
Sönke Liebau
Partner
Tel. +49 179 7940878
OpenCore GmbH & Co. KG - Thomas-Mann-Straße 8 - 22880 Wedel - Germany
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Just noticed ...
the problem is not when building the project (mvn clean package) but when building the site ... will investigate.
Chris
Am 24.01.20, 09:40 schrieb "Christofer Dutz" <ch...@c-ware.de>:
Argh ... just read this.
I just built everything with an empty repo and it worked without any problems.
Chris
Am 24.01.20, 03:42 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
Never mind I managed to sort it out.
Thanks,
Just
Re: build failing
Posted by Christofer Dutz <ch...@c-ware.de>.
Argh ... just read this.
I just built everything with an empty repo and it worked without any problems.
Chris
Am 24.01.20, 03:42 schrieb "Justin Mclean" <ju...@classsoftware.com>:
Hi,
Never mind I managed to sort it out.
Thanks,
Just
Re: build failing
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
Never mind I managed to sort it out.
Thanks,
Just