You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Sam TH <sa...@uchicago.edu> on 2001/02/03 12:40:17 UTC

Patch: squash a warning

This patch squashes one of the two current warnings in my build.  The
other is on line 77 of client/diff.c, where we have the following
strange construction:

  printf( "===================================================================\n", path->data );

What exactly is supposed to be printed here?

Ok, the patch:

* adm_crawler.c (svn_wc_crawl_revisions): Remove unused variable to
squash warning.  

Index: subversion/libsvn_wc/adm_crawler.c
===================================================================
RCS file: /cvs/subversion/subversion/libsvn_wc/adm_crawler.c,v
retrieving revision 1.71
diff -u -r1.71 adm_crawler.c
--- subversion/libsvn_wc/adm_crawler.c	2001/01/27 02:36:34	1.71
+++ subversion/libsvn_wc/adm_crawler.c	2001/02/03 12:30:30
@@ -1002,7 +1002,6 @@
   svn_error_t *err;
   svn_wc_entry_t *root_entry;
   svn_revnum_t master_revnum = SVN_INVALID_REVNUM;
-  struct stack_object *stack = NULL;
 
   /* The first thing we do is get the master_revnum from the
      working copy's ROOT_DIRECTORY.  This is the revnum that all

           
	sam th		     
	sam@uchicago.edu
	http://www.abisource.com/~sam/
	GnuPG Key:  
	http://www.abisource.com/~sam/key

Re: Patch: squash a warning

Posted by cm...@collab.net.
Sam TH <sa...@uchicago.edu> writes:

> This patch squashes one of the two current warnings in my build.  The
> other is on line 77 of client/diff.c, where we have the following
> strange construction:
> 
>   printf( "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n", path->d=
> ata );
> 
> What exactly is supposed to be printed here?

Oops.  I noticed this too, and have fixed it.  Hope you don't mind not
getting credit for seeing it as well.  I certainly get credit for
being the goofball that flubbed up that line of code. :-(