[jira] [Comment Edited] (DELTASPIKE-785) Make CdiTestRunner pick up container configuration from properties file

["Gerhard Petracek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DELTASPIKE-785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219439#comment-14219439 ] 

Gerhard Petracek edited comment on DELTASPIKE-785 at 11/20/14 3:28 PM:
-----------------------------------------------------------------------

@karl:
imo it's the responsibility of the container itself to provide different approaches to find such a config (via param. should be just one of it) and it's a feature which is just portable in theory since only one container (we support out-of-the-box) supports that at all.
however, i'm ok with that suggestion since it doesn't pollute the api itself.

@all:
everybody is welcome to suggest better names, however, we need "deltaspike." as prefix for the project-stage based config (since it can be provided by any config-source and that's our prefix we use already) and the default config for the test-container is META-INF/apache-deltaspike_test-container.properties since we have META-INF/apache-deltaspike.properties as name already and it should be clean for users that it isn't a config for deltaspike itself, instead it's a config picked up by deltaspike and forwarded to the test-container.
for sure we could reuse META-INF/apache-deltaspike.properties, but imo it's strange to see other deltaspike-config-values in the test-container (e.g. during debugging)


was (Author: gpetracek):
@karl:
imo it's the responsibility of the container itself to provide different approaches to find such a config (via param. should be just one of it) and it's a feature which is just portable in theory since only one container (we support out-of-the-box) supports that at all.
however, i'm ok with that suggestion since it doesn't pollute the api itself.

@all:
everybody is welcome to suggest better names, however, we need "deltaspike." as prefix for the project-stage based config (since it can be provided by any config-source and that's our prefix we use already) and the default config for the test-container is META-INF/apache-deltaspike_test-container.properties since we have META-INF/apache-deltaspike.properties as name already and it should be clean for users that it isn't a config for deltaspike itself, instead it's a config picked up by deltaspike and forwarded to the test-container.

> Make CdiTestRunner pick up container configuration from properties file
> -----------------------------------------------------------------------
>
>                 Key: DELTASPIKE-785
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-785
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: TestControl
>    Affects Versions: 1.1.0
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>             Fix For: 1.2.0
>
>
> For doing 'real' EE tests we need to be able to configure those containers when it boots up. CdiCtrl already has a boot(Properties) which we can use very easily. 
> That way openejb-embedded, glassfish-embedded and wildfly-embedded can e.g. register DataSources for the unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)