You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/27 17:15:00 UTC
[jira] [Work logged] (BEAM-8291)
org.apache.beam.sdk.schemas.AvroSchemaTest sensitive to system timezone
[ https://issues.apache.org/jira/browse/BEAM-8291?focusedWorklogId=319687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319687 ]
ASF GitHub Bot logged work on BEAM-8291:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 17:14
Start Date: 27/Sep/19 17:14
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #9678: [BEAM-8291] Always use UTC in generated code to convert to a LocalDate
URL: https://github.com/apache/beam/pull/9678
Modifies `ByteBuddyUtils` to generate `new T(value.getMillis(), DateTimeZone.UTC)`, whenever `T` is a sub-class of `BaseLocal`, rather than `new T(value.getMillis())`, which uses the default timezone.
Fixes some `AvroSchemaTest` failures that occurred on my local machine (I believe this would happen on any machine with a negative TZ offset).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
R: @reuvenlax
cc: @kanterov, @robinyqiu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 319687)
Remaining Estimate: 0h
Time Spent: 10m
> org.apache.beam.sdk.schemas.AvroSchemaTest sensitive to system timezone
> -----------------------------------------------------------------------
>
> Key: BEAM-8291
> URL: https://issues.apache.org/jira/browse/BEAM-8291
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Brian Hulette
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I noticed that AvroSchemaTest.{testRowToSpecificRecord, testRowToPojo} are failing on my local machine, but don't seem to fail on Jenkins. I looked into it a bit and it seems to be because my default timezone is America/Los_Angeles, but the ROW_FOR_POJO is initialized with an Instant at the start of the day in UTC
--
This message was sent by Atlassian Jira
(v8.3.4#803005)