You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/04/26 22:47:52 UTC

[kudu-CR] hms: mark latency flag as hidden

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13135


Change subject: hms: mark latency flag as hidden
......................................................................

hms: mark latency flag as hidden

Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
---
M src/kudu/master/hms_notification_log_listener.cc
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/35/13135/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13135 )

Change subject: hms: mark latency flag as hidden
......................................................................

hms: mark latency flag as hidden

Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Reviewed-on: http://gerrit.cloudera.org:8080/13135
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/hms_notification_log_listener.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Andrew Wong: Verified
  Adar Dembo: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] hms: mark latency flag as hidden

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 )

Change subject: hms: mark latency flag as hidden
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2019 01:02:07 +0000
Gerrit-HasComments: No

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 )

Change subject: hms: mark latency flag as hidden
......................................................................


Patch Set 1:

Retriggered. Looks like the failures are NTP-related.


-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:06:37 +0000
Gerrit-HasComments: No

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 )

Change subject: hms: mark latency flag as hidden
......................................................................


Patch Set 1: Verified+1

Seems like a test failed due to NTP issues. It's unrelated.

master_main.cc:80] Check failed: _s.ok() Bad status: Runtime error: Cannot initialize clock: failed to wait for clock sync using command '/usr/sbin/ntp-wait -s 1 -n 60': /usr/sbin/ntp-wait: process exited with non-zero status 1


-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2019 00:22:19 +0000
Gerrit-HasComments: No

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: hms: mark latency flag as hidden
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] hms: mark latency flag as hidden

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13135 )

Change subject: hms: mark latency flag as hidden
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 27 Apr 2019 01:00:16 +0000
Gerrit-HasComments: No

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: hms: mark latency flag as hidden
......................................................................


Removed -Verified by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] hms: mark latency flag as hidden

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.

Change subject: hms: mark latency flag as hidden
......................................................................


Removed -Verified by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13135
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ib11848a262a1d9329a3981c7f7eafb99134fae75
Gerrit-Change-Number: 13135
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)