You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Simeon Simeonov (JIRA)" <ji...@apache.org> on 2018/10/18 14:15:00 UTC

[jira] [Created] (SPARK-25769) UnresolvedAttribute.sql() incorrectly escapes nested columns

Simeon Simeonov created SPARK-25769:
---------------------------------------

             Summary: UnresolvedAttribute.sql() incorrectly escapes nested columns
                 Key: SPARK-25769
                 URL: https://issues.apache.org/jira/browse/SPARK-25769
             Project: Spark
          Issue Type: Bug
          Components: SQL
    Affects Versions: 2.3.2
            Reporter: Simeon Simeonov


 

This issue affects dynamic SQL generation that relies on {{sql()}}.

 
{code:java}
import org.apache.spark.sql.catalyst.analysis.UnresolvedAttribute

// The correct output is a.b, without backticks, or `a`.`b`.
$"a.b".expr.asInstanceOf[UnresolvedAttribute].sql
// res2: String = `a.b`

// Parsing is correct; the bug is localized to sql() 
$"a.b".expr.asInstanceOf[UnresolvedAttribute].nameParts 
// res1: Seq[String] = ArrayBuffer(a, b)
{code}
 

The likely culprit is that the {{sql()}} implementation does not check for {{nameParts}} being non-empty.

 

 
{code:java}
override def sql: String = name match { 
  case ParserUtils.escapedIdentifier(_) | ParserUtils.qualifiedEscapedIdentifier(_, _) => name 
  case _ => quoteIdentifier(name) 
}
{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org