You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/25 12:32:07 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
acassis opened a new pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644
## Summary
Move serial console from USART6 to USART1
## Impact
User will be able to use the Virtual COM port directly
## Testing
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
ghn-certi commented on a change in pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644#discussion_r476452744
##########
File path: boards/arm/stm32f7/stm32f746g-disco/README.txt
##########
@@ -98,16 +98,20 @@ LEDs and Buttons
Serial Console
==============
- These configurations assume that you are using a standard Arduio RS-232
- shield with the serial interface with RX on pin D0 and TX on pin D1:
+ The STM32F469G-DISCO uses USART1 connected to "Virtual COM", so when you
+ plug it on your computer it will be detected as a USB port (i.e. ttyACM0):
-------- ---------------
STM32F7
- ARDUIONO FUNCTION GPIO
- -- ----- --------- -----
- DO RX USART6_RX PC7
- D1 TX USART6_TX PC6
- -- ----- --------- -----
+ V.COM FUNCTION GPIO
+ ----- --------- -----
+ RXD USART6_RX PB7
Review comment:
```suggestion
RXD USART1_RX PB7
```
##########
File path: boards/arm/stm32f7/stm32f746g-disco/README.txt
##########
@@ -98,16 +98,20 @@ LEDs and Buttons
Serial Console
==============
- These configurations assume that you are using a standard Arduio RS-232
- shield with the serial interface with RX on pin D0 and TX on pin D1:
+ The STM32F469G-DISCO uses USART1 connected to "Virtual COM", so when you
+ plug it on your computer it will be detected as a USB port (i.e. ttyACM0):
-------- ---------------
STM32F7
- ARDUIONO FUNCTION GPIO
- -- ----- --------- -----
- DO RX USART6_RX PC7
- D1 TX USART6_TX PC6
- -- ----- --------- -----
+ V.COM FUNCTION GPIO
+ ----- --------- -----
+ RXD USART6_RX PB7
+ TXD USART6_TX PA9
Review comment:
```suggestion
TXD USART1_TX PA9
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644#issuecomment-680250518
There are other places in the README where USART6 is still referenced.
Like the one under NOTES, STATUS and Configuration Directories/nsh (it's called UART6 there)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644#issuecomment-680777884
@acassis please squash the commits so we can merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644#issuecomment-680124446
Thank you Gustavo!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1644: stm32f746g-disco: Move serial console from USART6 to USART1 (Virtual …
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1644:
URL: https://github.com/apache/incubator-nuttx/pull/1644#issuecomment-680936837
> @acassis please squash the commits so we can merge it.
Done, thank you Abde!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org