You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/05/10 17:02:33 UTC
[GitHub] [trafficcontrol] rob05c opened a new issue #5829: Add t3c flag to avoid systemd
rob05c opened a new issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829
Right now, t3c (and ORT before it) call systemd to reload and restart services. This doesn't work with the CiaB, which doesn't have systemd on its cache Docker container. This could also be an issue if someone wanted to run t3c on a machine without SystemD.
We should
1. add a flag to t3c to not use systemd/systemctl/service if they don't exist (maybe a ternary like the git flag: use, use if exists, don't use)
2. attempt to use ATS' own reload/restart command (`traffic_ctl` or `trafficserver`) if systemd/systemctl/service doesn't exit or fails.
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
- For *SUPPORT QUESTIONS*, use the Traffic Control slack (https://s.apache.org/atc-slack)
or Traffic Control mailing lists (https://trafficcontrol.apache.org/mailing_lists).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR.
-->
## I'm submitting a ...
<!-- delete all those that don't apply -->
<!--- security vulnerability (STOP!! - see above)-->
- new feature / enhancement request
- other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- delete all those that don't apply -->
- CDN in a Box
- Documentation
- Grove
- Traffic Control Client
- Traffic Monitor
- Traffic Ops
- Traffic Ops ORT
- Traffic Portal
- Traffic Router
- Traffic Stats
- Traffic Vault
- CI tests
- unknown
## Current behavior:
<!-- Describe how the current features are insufficient. -->
## New behavior:
<!-- Describe how the feature would improve Traffic Control -->
## Minimal reproduction of the problem with instructions:
<!--
If you can illustrate your feature request better with an example, please
provide the *STEPS TO REPRODUCE* and include the applicable TC version.
If not, feel free to delete this section.
-->
## Anything else:
<!--
e.g. additional context, related issues, suggestions about how to approach (feel
free to delete this section)
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c edited a comment on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
rob05c edited a comment on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838662547
I feel like it'd be valuable anyway, not just for the CiaB, to have a flag that says "never do system stuff," so someone could allow it to work in other environments, not just Docker, or if they want to do that with an automation tool like Ansible or Puppet instead of t3c. A general ternary flag to "use system / call ATS directly / don't call anything" just seems like it'd give users more power and flexibility, for however they want to operate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford edited a comment on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
jrushford edited a comment on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838674763
Or just modify t3c to call the trafficserver init script directly instead of using OS tools. Systemd doesn't really add any value to stop/starting ATS anyway. FreeBSD and Ubuntu use the script directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838674763
Or just modify t3c to call the trafficserver init script directly instead of using OS tools. Systemd doesn't really add any value to stop/starting ATS anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
rob05c commented on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838662547
I feel like it'd be valuable anyway, not just for the CiaB, to have a flag that says "never do system stuff," so someone could allow it to work in other environments, not just Docker, or if they want to do that with an automation tool like Ansible or Puppet instead of t3c. A general ternary flag to "use system / call ATS directly to reload/restart / don't call anything" just seems like it'd give users more power and flexibility, for however they want to operate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford edited a comment on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
jrushford edited a comment on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838640084
@zrhoffman I ran into this issue with the CentOS 7 docker container used as part of the ORT integration tests. Since the ORT integration tests were not dependent on ATS actually running, I replaced systemctl in the docker container with a bash script to return 0 so that t3c would succeed. This approach could be used in CIAB but the replacement script could actually run the /opt/trafficserver/bin/trafficserver init script. I really don't think the t3c flag is necessary IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on issue #5829: Add t3c flag to avoid systemd
Posted by GitBox <gi...@apache.org>.
jrushford commented on issue #5829:
URL: https://github.com/apache/trafficcontrol/issues/5829#issuecomment-838640084
@zrhoffman I ran into this issue with the CentOS 7 docker container used as part of the ORT integration tests. Since the ORT integration tests were not dependent on ATS actually running, I replaced systemctl in the docker container with a bash script to return 0 so that t3c would succeed. This approach could be used in CIAB but the replacement script could actually run the /opt/trafficserver/bin/trafficserver init script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org