You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/10/23 20:19:35 UTC

[jira] [Commented] (THRIFT-2654) reduce number of server exceptions

    [ https://issues.apache.org/jira/browse/THRIFT-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181704#comment-14181704 ] 

Hudson commented on THRIFT-2654:
--------------------------------

SUCCESS: Integrated in Thrift #1324 (See [https://builds.apache.org/job/Thrift/1324/])
THRIFT-2654 reduce number of server exceptions (jensg: rev 902b7af4c84b8f716668d4d4f10612c16109c09a)
* lib/csharp/src/Transport/TTransport.cs


> reduce number of server exceptions
> ----------------------------------
>
>                 Key: THRIFT-2654
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2654
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2654-reduce-number-of-server-exceptions__additional.patch
>
>
> GitHub user captncraig opened a pull request:
>     https://github.com/apache/thrift/pull/177
>     C# - reduce number of server exceptions
>     The current server implementation reads in a loop until the client closes, at which point an exception is thrown by the processor/transport and caught by the server.
>     
>     I solve this by creating a smarter peek functionality in TTransport which reads and caches a byte from the underlying transport and reinserts it in ReadAll.  
> You can merge this pull request into a Git repository by running:
>     $ git pull https://github.com/captncraig/thrift transport-peek
> Alternatively you can review and apply these changes as the patch at:
>     https://github.com/apache/thrift/pull/177.patch
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>     This closes #177



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)