You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/22 15:02:14 UTC
[GitHub] [solr] jebnix opened a new pull request, #1112: Fixing the recommendation of using INIT_SOLR_HOME for new versions
jebnix opened a new pull request, #1112:
URL: https://github.com/apache/solr/pull/1112
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The docs says:
> Solr docker supports a INIT_SOLR_HOME setting, which copies the contents
but [this section](https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/deployment-guide/pages/solr-in-docker.adoc#updating-from-solr-5-7-to-8) says:
> The custom SOLR_HOME can no longer be used because various scripts depend on the new locations. Consequently, INIT_SOLR_HOME is also no longer supported.
So that seems like an invalid suggestion.
# Solution
Fixing
# Tests
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fixing the recommendation of using INIT_SOLR_HOME for new versions [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1112:
URL: https://github.com/apache/solr/pull/1112#issuecomment-1951329550
@jebnix this one too I think could be improved by just removing the updates.. Heck, this docs are going on Solr 10 and Solr 9 :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1112: Fixing the recommendation of using INIT_SOLR_HOME for new versions
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1112:
URL: https://github.com/apache/solr/pull/1112#issuecomment-1287901256
Thanks for giving the docs some love. Lots of the docker related docs is slightly outdated, and was copied from the old docker-solr repo into the ref guide.
Apart from `INIT_SOLR_HOME` no longer being supported (I found no reference to it), Solr will also now accept an empty `SOLR_HOME` and will automatically fall back to defaults for `solr.xml` and `zoo.cfg`. So there is no need for special init anymore. But any custom folder you point to must already exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fixing the recommendation of using INIT_SOLR_HOME for new versions [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy closed pull request #1112: Fixing the recommendation of using INIT_SOLR_HOME for new versions
URL: https://github.com/apache/solr/pull/1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1112: Fixing the recommendation of using INIT_SOLR_HOME for new versions
Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1112:
URL: https://github.com/apache/solr/pull/1112#discussion_r1069479829
##########
solr/solr-ref-guide/modules/deployment-guide/pages/docker-faq.adoc:
##########
@@ -140,7 +140,7 @@ docker run -it -v $PWD/mysolrhome:/mysolrhome -e SOLR_HOME=/mysolrhome solr
This does need a pre-configured directory at that location.
-To make this easier, Solr docker supports a INIT_SOLR_HOME setting, which copies the contents
+Until version 7, Solr docker supported an INIT_SOLR_HOME setting, which copies the contents
Review Comment:
Better, just remove the entire mention of `INIT_SOLR_HOME`. We don't normally document earlier versions in ref guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] jebnix commented on pull request #1112: Fixing the recommendation of using INIT_SOLR_HOME for new versions
Posted by GitBox <gi...@apache.org>.
jebnix commented on PR #1112:
URL: https://github.com/apache/solr/pull/1112#issuecomment-1288189961
@janhoy [The reference for `INIT_SOLR_HOME` not being supported](https://github.com/apache/solr/blob/main/solr/solr-ref-guide/modules/deployment-guide/pages/solr-in-docker.adoc#updating-from-solr-5-7-to-8) says:
> The custom SOLR_HOME can no longer be used because various scripts depend on the new locations. Consequently, INIT_SOLR_HOME is also no longer supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Fixing the recommendation of using INIT_SOLR_HOME for new versions [solr]
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1112:
URL: https://github.com/apache/solr/pull/1112#issuecomment-1951425038
Closing this, since #2277 will rewrite the entire paragraph.
Also, Solr can now work with an empty `SOLR_HOME` so this was old info anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org