You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2014/11/12 15:53:32 UTC
[DISCUSS] Release Flex-Tool-API?
Hi Guys,
I have finished implementing the flex-tool-api in the flex-sdk, falcon, falconjy and Flexmojos and all seems to be playing together nicely. During the process I added some minor changes to my initial version but now I think it's as finished as it needs to be. So I would like to initiate a Maven release of it.
In order to check everything is ok, check it out form the flex-utilities project.
If you run:
mvn -Papache-release install
you will get the jar, the source.jar as well as the javadoc.jar and the source-release.jar
The last of these seems to the the thing we have to vote upon. As soon as you give me a go, I would stage a release, which would deploy the release artifacts to the Apache Maven staging repository and we could start the official voting process.
Chris
AW: [DISCUSS] Release Flex-Tool-API?
Posted by Christofer Dutz <ch...@c-ware.de>.
I just remember what the problem was that as part of a release each file of a release is signed and as soon as I turn on the apache-release profile it expects credentials for this signing process.
If I don't turn on the apache-release profile the configuration settings for the assembly plugin are not available.
Chris
________________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Mittwoch, 12. November 2014 21:47
An: dev@flex.apache.org
Betreff: AW: [DISCUSS] Release Flex-Tool-API?
In a "install" run the needed parts of maven don't run as they come when running the site and the deploy phase (which would have come after install) ... If I however run deploy things would get deployed. Don't want to screw things up here ... but I could give it a try tomorrow.
Chris
________________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Mittwoch, 12. November 2014 18:31
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Flex-Tool-API?
On 11/12/14, 6:53 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>If you run:
>
>
>mvn -Papache-release install
Chris,
Is there any reason we can’t add this to the CI build? It will save folks
time trying to poke at what might get released.
-Alex
AW: [DISCUSS] Release Flex-Tool-API?
Posted by Christofer Dutz <ch...@c-ware.de>.
In a "install" run the needed parts of maven don't run as they come when running the site and the deploy phase (which would have come after install) ... If I however run deploy things would get deployed. Don't want to screw things up here ... but I could give it a try tomorrow.
Chris
________________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Mittwoch, 12. November 2014 18:31
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Flex-Tool-API?
On 11/12/14, 6:53 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>If you run:
>
>
>mvn -Papache-release install
Chris,
Is there any reason we can’t add this to the CI build? It will save folks
time trying to poke at what might get released.
-Alex
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I've also made an attempt to fix the pom, but don't 100% really know what I'm doing or what the values typically should be.
The SCM section incorrectly referred to SVN rather than Git, while I've fixed that I'm fairly certain the SMC entries developer and developerConnection are still incorrect. [1]
Thanks,
Justin
1, http://maven.apache.org/pom.html#SCM
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Erik de Bruin <er...@ixsoftware.nl>.
> Hmmm ... well I prepared the release (Removed the SNAPSHOT from the
> version) and tagged that version so it's exactly the version in the
> distribution.
>
> After publishing the release version, I updated the version of the project
> for the next development iteration to 1.1.0-SNAPSHOT. This is the commit
> with version 7969f7a. If I had tagged that it would have been wrong.
>
> I sort of don't get the problem.
>
> And to the spelling "errors":
> - I definitely wouldn't call errors such as: "Apaches" instead of the
> correct "Apache's" and "bugbase" instead of "bug base" as blocker errors ;-)
> - And please don't let us discuss things like z's ad s's, american english
> or british english as long as it's not klingon english I'll probably
> understand ;-) ... If anyone encounters something like that --> Fix it ...
> discussing such things in lengthy email threads is totally fu**ing up my
> motivation to contribute at all.
+2, up to and including the profanity.
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I sort of don't get the problem.
The released pom.xml has this:
<connection>scm:svn:https://git-wip-us.apache.org/repos/asf/flex-utilities.git/tags/flex-tool-api-1.0.0-RC1</connection>
<developerConnection>scm:svn:https://git-wip-us.apache.org/repos/asf/flex-utilities.git/tags/flex-tool-api-1.0.0-RC1</developerConnection>
The paths are incorrect and the protocol should be git not svn (not the scm:svn at the front)
As I said it's a minor issue along with a few others (and hence my +0 vote) but this one may be one that causes issues. Any idea if it will or not?
> - I definitely wouldn't call errors such as: "Apaches" instead of the correct "Apache's" and "bugbase" instead of "bug base" as blocker errors ;-)
Neither would I.
Thanks,
Justin
Re: AW: [DISCUSS] Release Flex-Tool-API?
Posted by OmPrakash Muppirala <bi...@gmail.com>.
I don't think anyone called those spelling errors as blockers.
As Erik mentioned, you have enough votes to release. As Release Manager,
you can end this discussion by sending out a vote result email.
Also, just because someone calls a bug a blocker, it does not become one.
A majority of the voters must consider it a blocker and vote -1, which has
obviously not happened here.
Thanks,
Om
On Nov 15, 2014 9:48 AM, "Christofer Dutz" <ch...@c-ware.de>
wrote:
> Hmmm ... well I prepared the release (Removed the SNAPSHOT from the
> version) and tagged that version so it's exactly the version in the
> distribution.
>
> After publishing the release version, I updated the version of the project
> for the next development iteration to 1.1.0-SNAPSHOT. This is the commit
> with version 7969f7a. If I had tagged that it would have been wrong.
>
> I sort of don't get the problem.
>
> And to the spelling "errors":
> - I definitely wouldn't call errors such as: "Apaches" instead of the
> correct "Apache's" and "bugbase" instead of "bug base" as blocker errors ;-)
> - And please don't let us discuss things like z's ad s's, american english
> or british english as long as it's not klingon english I'll probably
> understand ;-) ... If anyone encounters something like that --> Fix it ...
> discussing such things in lengthy email threads is totally fu**ing up my
> motivation to contribute at all.
>
> Chris
>
> ________________________________________
> Von: Justin Mclean <ju...@classsoftware.com>
> Gesendet: Samstag, 15. November 2014 09:11
> An: dev@flex.apache.org
> Betreff: Re: [DISCUSS] Release Flex-Tool-API?
>
> Hi,
>
> >> Also of a concern is that the pom.xml in version control doesn't match
> >> the one in the distribution. That's probably a blocker and needs to be
> >> fixed.
>
> Sorry ignore that it does look OK - myself and git were having a
> disagreement.
>
> It does look to me that perhaps the tag/build was done one one commit too
> early? ie dfd7067 instead of 7969f7a. That would explain some of the issues
> with the pom.xml
>
> Thanks,
> Justin
AW: [DISCUSS] Release Flex-Tool-API?
Posted by Christofer Dutz <ch...@c-ware.de>.
Hmmm ... well I prepared the release (Removed the SNAPSHOT from the version) and tagged that version so it's exactly the version in the distribution.
After publishing the release version, I updated the version of the project for the next development iteration to 1.1.0-SNAPSHOT. This is the commit with version 7969f7a. If I had tagged that it would have been wrong.
I sort of don't get the problem.
And to the spelling "errors":
- I definitely wouldn't call errors such as: "Apaches" instead of the correct "Apache's" and "bugbase" instead of "bug base" as blocker errors ;-)
- And please don't let us discuss things like z's ad s's, american english or british english as long as it's not klingon english I'll probably understand ;-) ... If anyone encounters something like that --> Fix it ... discussing such things in lengthy email threads is totally fu**ing up my motivation to contribute at all.
Chris
________________________________________
Von: Justin Mclean <ju...@classsoftware.com>
Gesendet: Samstag, 15. November 2014 09:11
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Flex-Tool-API?
Hi,
>> Also of a concern is that the pom.xml in version control doesn't match
>> the one in the distribution. That's probably a blocker and needs to be
>> fixed.
Sorry ignore that it does look OK - myself and git were having a disagreement.
It does look to me that perhaps the tag/build was done one one commit too early? ie dfd7067 instead of 7969f7a. That would explain some of the issues with the pom.xml
Thanks,
Justin
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> Also of a concern is that the pom.xml in version control doesn't match
>> the one in the distribution. That's probably a blocker and needs to be
>> fixed.
Sorry ignore that it does look OK - myself and git were having a disagreement.
It does look to me that perhaps the tag/build was done one one commit too early? ie dfd7067 instead of 7969f7a. That would explain some of the issues with the pom.xml
Thanks,
Justin
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Alex Harui <ah...@adobe.com>.
On 11/14/14, 11:01 PM, "Justin Mclean" <ju...@me.com> wrote:
>HI,
>
>Also of a concern is that the pom.xml in version control doesn't match
>the one in the distribution. That's probably a blocker and needs to be
>fixed.
I pulled the pom.xml for the hash in the tag. It matched the distribution
for me. What diffs did you see? I’m packing it in for tonight so I’ll
look for your answer tomorrow.
-Alex
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@me.com>.
HI,
Also of a concern is that the pom.xml in version control doesn't match the one in the distribution. That's probably a blocker and needs to be fixed.
Thanks,
Justin
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I forgot to manually push the tag ... after doing so the tag should now be available.
Thanks.
> So I guess this issue can be treated as resolved.
And the other pom issues?
> Regarding any mis-spellings ...
Depends on if you going to make another release or not, given this in unlikely to be released again is there much point if we don't have another RC.
Thanks,
Justin
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Regarding any mis-spellings ...
I made some fixes/improvements, feel free to alter as you see fit.
I'm certainly not an expert when it come to the English language and I'm sure there's many foreign speakers that spell better than me (as they learnt it rather than absorbed it). Going to 30+ schools probably had something to do with it as well.
You might also want to put together a draft announcement and post to the list.
Thanks,
Justin
PS IMO It's a good idea to have a JIRA to track this release and any sub tasks, that way nothing gets forgotten. eg https://issues.apache.org/jira/browse/FLEX-34612
AW: [DISCUSS] Release Flex-Tool-API?
Posted by Christofer Dutz <ch...@c-ware.de>.
I forgot to manually push the tag ... after doing so the tag should now be available.
So I guess this issue can be treated as resolved.
Regarding any mis-spellings ... well ... why don't you just fix what you found, cause just saying "there are spelling errors" sort of isn't that much help. After all ... we're not all born English ... for me "spelling is an assho**" and always has been so feel free to fix ;-)
Chris
________________________________________
Von: Justin Mclean <ju...@classsoftware.com>
Gesendet: Freitag, 14. November 2014 12:46
An: dev@flex.apache.org
Betreff: Re: [DISCUSS] Release Flex-Tool-API?
Hi,
I'm jet lagged and still travelling so please excuse any sillly mistakes I make here.
- LICENSE and NOTICE correct
- all source files have correct headers
- no binaries in release
- can compile from source
Only minor things I noticed where:
- The artefact name should have "apache" in it as this gives some extra legal protection, not required but it's a good idea.
- README has a couple of minor spelling errors
I also noticed a couple of things in the pom that may need fixing:
1. mailing list list user mailing list only, if only one mailing list is listed it probably should be the dev one
2. scm details look incorrect to me (looks like https://git-wip-us.apache.org/repos/asf/flex-utilities.git/tags/flex-tool-api-1.0.0-RC1 doesn't exist and that would not be the final URL right?) Probably need to be fixed before releasing.
3. Does the target/source values of 1.6 mens it targeting Java 1.6? Should we be targeting 1.7?
Also while compiling I got this:
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/justinmclean/Downloads/flex-tool-api-1.0.0/src/main/resources
[INFO] Copying 3 resources
Seems a little odd that it copies 3 resource but the resource directory doesn't exist.
Thanks,
Justin
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
I'm jet lagged and still travelling so please excuse any sillly mistakes I make here.
- LICENSE and NOTICE correct
- all source files have correct headers
- no binaries in release
- can compile from source
Only minor things I noticed where:
- The artefact name should have "apache" in it as this gives some extra legal protection, not required but it's a good idea.
- README has a couple of minor spelling errors
I also noticed a couple of things in the pom that may need fixing:
1. mailing list list user mailing list only, if only one mailing list is listed it probably should be the dev one
2. scm details look incorrect to me (looks like https://git-wip-us.apache.org/repos/asf/flex-utilities.git/tags/flex-tool-api-1.0.0-RC1 doesn't exist and that would not be the final URL right?) Probably need to be fixed before releasing.
3. Does the target/source values of 1.6 mens it targeting Java 1.6? Should we be targeting 1.7?
Also while compiling I got this:
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /Users/justinmclean/Downloads/flex-tool-api-1.0.0/src/main/resources
[INFO] Copying 3 resources
Seems a little odd that it copies 3 resource but the resource directory doesn't exist.
Thanks,
Justin
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Here's how to install Maven on Windows:
http://www.mkyong.com/maven/how-to-install-maven-in-windows/
Thanks,
Om
On Nov 13, 2014 11:19 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
>
> On 11/13/14, 11:03 PM, "piotrz" <pi...@gmail.com> wrote:
>
> >Now it's working. Thanks once again.
> >
> >Build failed using approve file. I got this error ->
> >http://images.devs-on.net/Image/dwQgNsHuJ2hoVFNB-Obszar.png
>
> Can you run mvn on the command-line? Maybe in Windows it needs to be
> mvn.exe?
>
> -Alex
>
>
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by Alex Harui <ah...@adobe.com>.
On 11/13/14, 11:03 PM, "piotrz" <pi...@gmail.com> wrote:
>Now it's working. Thanks once again.
>
>Build failed using approve file. I got this error ->
>http://images.devs-on.net/Image/dwQgNsHuJ2hoVFNB-Obszar.png
Can you run mvn on the command-line? Maybe in Windows it needs to be
mvn.exe?
-Alex
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by piotrz <pi...@gmail.com>.
Now it's working. Thanks once again.
Build failed using approve file. I got this error ->
http://images.devs-on.net/Image/dwQgNsHuJ2hoVFNB-Obszar.png
But launching it from pom without using approve file project build.
Something probably is wrong with my environment or approve file itself.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/DISCUSS-Release-Flex-Tool-API-tp42286p42341.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by Alex Harui <ah...@adobe.com>.
On 11/13/14, 10:23 PM, "piotrz" <pi...@gmail.com> wrote:
>Thanks Alex,
>
>This web site is password protected -> http://keys.gnupg.net
>How can I login there ?
I just get a web page where I can type in a key id. No login required.
Try this server: https://pgp.mit.edu
-Alex
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by piotrz <pi...@gmail.com>.
Thanks Alex,
This web site is password protected -> http://keys.gnupg.net
How can I login there ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/DISCUSS-Release-Flex-Tool-API-tp42286p42339.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by Alex Harui <ah...@adobe.com>.
On 11/13/14, 2:47 PM, "piotrz" <pi...@gmail.com> wrote:
>Alex,
>
>I didn't want to mess a VOTE thread so asking here.
>What do you mean saying "I grabbed your key from a keys server and then
>the
>signature could be verified. " ? - Probably I miss something obvious.
>Where is this "keys server".
Good move switching to [DISCUSS].
There are some popular key servers on the internet. I found Chris’s key
here:
http://keys.gnupg.net
His key id is: 0x5B288057
That should result in this huge block of ASCII. Copy the entire thing to
a text file, then run:
gpg --import <text file>
That should add the key to your list of keys so gpg can verify it. (I
don’t know if my mail client will munge the command, but that’s two ‘-‘ in
front of the word ‘import’)
Then the approval script should be able to guide you through the approval
process.
Thanks for being a release reviewer,
-Alex
Re: AW: AW: AW: [DISCUSS] Release Flex-Tool-API?
Posted by piotrz <pi...@gmail.com>.
Alex,
I didn't want to mess a VOTE thread so asking here.
What do you mean saying "I grabbed your key from a keys server and then the
signature could be verified. " ? - Probably I miss something obvious.
Where is this "keys server".
I wanted to vote for Chris's flex tool api.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/DISCUSS-Release-Flex-Tool-API-tp42286p42326.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [DISCUSS] Release Flex-Tool-API?
Posted by Alex Harui <ah...@adobe.com>.
On 11/12/14, 6:53 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>If you run:
>
>
>mvn -Papache-release install
Chris,
Is there any reason we can’t add this to the CI build? It will save folks
time trying to poke at what might get released.
-Alex