[jira] [Comment Edited] (OAK-5106) Reuse NioEventLoopGroup in standby client

["Timothee Maret (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664884#comment-15664884 ] 

Timothee Maret edited comment on OAK-5106 at 11/14/16 8:52 PM:
---------------------------------------------------------------

Attach a svn patch that
* Reuse the NioEventLoopGroup in the standby client
* Fix a file handler leak in tests (the server NioEventLoopGroup was not released)


was (Author: marett):
Attach a svn patch that
* Reuse the NioEventLoopGroup in the standby client
* Fix a memory leak in tests (the server NioEventLoopGroup was not released)

> Reuse NioEventLoopGroup in standby client
> -----------------------------------------
>
>                 Key: OAK-5106
>                 URL: https://issues.apache.org/jira/browse/OAK-5106
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>    Affects Versions: 1.5.13
>            Reporter: Timothee Maret
>            Assignee: Timothee Maret
>             Fix For: 1.5.14
>
>         Attachments: OAK-5106.patch
>
>
> The Standby client code does instantiate a new {{NioEventLoopGroup}} for every cycle (5 seconds). The standby tests do instantiate many {{NioEventLoopGroup}}.
> Although {{NioEventLoopGroup}} are closed properly, each of them consume files and management overhead (seting up/down). An improvement would be to reuse the {{NioEventLoopGroup}} in standby client across polling cycles and reuse {{NioEventLoopGroup}} in the test code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)