You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "volosied (via GitHub)" <gi...@apache.org> on 2023/10/03 14:41:39 UTC
[PR] MYFACES-4631 [myfaces]
volosied opened a new pull request, #614:
URL: https://github.com/apache/myfaces/pull/614
https://issues.apache.org/jira/browse/MYFACES-4631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4631 [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #614:
URL: https://github.com/apache/myfaces/pull/614#issuecomment-1746462262
can you please add a test for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4631 [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #614:
URL: https://github.com/apache/myfaces/pull/614#issuecomment-1754200610
Tried to create a simple test, but it doesn't quite match the scenario reported primefaces extensions.
For example, my test showed the ids rendered:
```
<ComponentResourceContainer id="jakarta_faces_location_head" facetName="head" clientBehaviors="{}" clientId="jakarta_faces_location_head" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Panel" inView="true" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="NULL" rendersChildren="false" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@302a1ddc">
<UIOutput id="j_id__v_0" clientBehaviors="{}" clientId="j_id__v_0" converter="NULL" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Output" inView="true" localValue="NULL" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="jakarta.faces.resource.Script" rendersChildren="true" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@1b9674f4">
<UIOutput id="j_id__v_4" clientBehaviors="{}" clientId="j_id__v_4" converter="NULL" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Output" inView="true" localValue="console.log('added script');" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="jakarta.faces.Text" rendersChildren="false" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@361d4b4d"/>
</UIOutput>
<UIOutput id="j_id__v_2" library="jakarta.faces" name="faces.js" target="head" clientBehaviors="{}" clientId="j_id__v_2" converter="NULL" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Output" inView="true" localValue="NULL" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="jakarta.faces.resource.Script" rendersChildren="true" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@27bb0910"/>
<UIOutput id="j_id__v_3" clientBehaviors="{}" clientId="j_id__v_3" converter="NULL" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Output" inView="true" localValue="NULL" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="jakarta.faces.resource.Script" rendersChildren="true" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@479f34c6">
<UIOutput id="j_id__v_5" clientBehaviors="{}" clientId="j_id__v_5" converter="NULL" defaultEventName="NULL" eventNames="NULL" facetCount="0" family="jakarta.faces.Output" inView="true" localValue="console.log('added script');" namingContainer="NULL" passThroughAttributes="jakarta.faces.component._PassThroughAttributesMap@0" rendered="true" rendererType="jakarta.faces.Text" rendersChildren="false" resourceBundleMap="{}" transient="false" transientStateHelper="jakarta.faces.component._DeltaStateHelper@6f86c915"/>
</UIOutput>
</ComponentResourceContainer>
```
ResourceDependencies may have a part of play in the bug the number of scripts? I'll have to debug a bit further here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4631 [myfaces]
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #614:
URL: https://github.com/apache/myfaces/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MYFACES-4631 [myfaces]
Posted by "volosied (via GitHub)" <gi...@apache.org>.
volosied commented on PR #614:
URL: https://github.com/apache/myfaces/pull/614#issuecomment-1755941400
I'm not able to recreate a simple test here, but the fix looks right as far I can tell. I will also preform TCK testing later on to verify no regressions occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org