You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jerome Lacoste (JIRA)" <ji...@codehaus.org> on 2006/04/13 03:34:48 UTC
[jira] Commented: (MJAR-27) jar:sign doesn't check if project
prouces an artifact
[ http://jira.codehaus.org/browse/MJAR-27?page=comments#action_63461 ]
Jerome Lacoste commented on MJAR-27:
------------------------------------
I've been asked to provide a test case for the issue. It's true that the attached patch doesn't provide one. On the other side, same issue was reported and fixed in 2 different mojos in a different plugin:
http://svn.mojo.codehaus.org/trunk/mojo/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaInstrumentMojo.java?view=diff&r1=1722&r2=1721&p1=trunk/mojo/mojo-sandbox/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaInstrumentMojo.java&p2=/trunk/mojo/mojo-sandbox/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaInstrumentMojo.java
http://svn.mojo.codehaus.org/trunk/mojo/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaCheckMojo.java?view=diff&r1=1723&r2=1722&p1=trunk/mojo/mojo-sandbox/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaCheckMojo.java&p2=/trunk/mojo/mojo-sandbox/cobertura-maven-plugin/src/main/java/org/codehaus/mojo/cobertura/CoberturaCheckMojo.java
Is that sufficient? If not, Michael, feel free to write a test case for your issue if you want it to be checked in faster.
> jar:sign doesn't check if project prouces an artifact
> -----------------------------------------------------
>
> Key: MJAR-27
> URL: http://jira.codehaus.org/browse/MJAR-27
> Project: Maven 2.x Jar Plugin
> Type: Bug
> Environment: Maven 2.0.2
> Latest Jar checkout
> Reporter: Michael Böckling
> Attachments: MJAR-27-maven-jar-plugin.diff, MJAR-27-maven-jar-plugin.patch, MJAR-27-maven-jar-plugin.patch, jarsign-patch.txt
>
>
> jar:sign does not skip projects that don't produce an artifact (=pom packaging).
> Attached patch to detect this situation and handle it gracefully.
> Since similar issues showed up in the Javadoc and Cobertura plugin, too, I was wondering if an additional mojo annotation like @requireLanguage (project must have e.e. java as its language) or @requireArtifact (don't execute if this project does not create an artifact, e.g. has pom packaging) would make sense.
> Stuff like this makes it much harder to establish a company-wide standardized build process, since there are always pom projects in the inheritance hierarchy...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira